Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add quota admission test for decreasing usage without covering quota #77342

Merged
merged 1 commit into from
May 3, 2019
Merged

Add quota admission test for decreasing usage without covering quota #77342

merged 1 commit into from
May 3, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented May 2, 2019 •
edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

  • Updates the delta quota tests to check a specific global quota
  • Tests increasing and decreasing usage without a covering quota separately

Special notes for your reviewer:
Follow-up from #76299

Does this PR introduce a user-facing change?:

NONE

/priority backlog
/sig api-machinery

@k8s-ci-robot
Copy link
Contributor

@liggitt: GitHub didn't allow me to request PR reviews from the following users: mansi-a.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

  • Updates the delta quota tests to check a specific global quota
  • Tests increasing and decreasing usage without a covering quota separately

Special notes for your reviewer:
Follow-up from #76299

Does this PR introduce a user-facing change?:

NONE

/cc @mansi-a
/priority backlog
/sig api-machinery

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. priority/backlog Higher priority than priority/awaiting-more-evidence. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 2, 2019
@mansi-a
Copy link
Contributor

mansi-a commented May 2, 2019 •
edited

I officially can't review but the tests look good.

@liggitt
Copy link
Member Author

liggitt commented May 2, 2019

/retest

@liggitt
Copy link
Member Author

liggitt commented May 2, 2019

/cc @derekwaynecarr

@liggitt
Copy link
Member Author

liggitt commented May 2, 2019

/retest

@apelisse
Copy link
Member

apelisse commented May 2, 2019

/assign @yliaog

@yliaog
Copy link
Contributor

yliaog commented May 3, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7a8e11c into kubernetes:master May 3, 2019
@liggitt liggitt deleted the resource-quota branch May 6, 2019 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liggitt @k8s-ci-robot @mansi-a @apelisse @yliaog