Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #76299: Short-circuit quota admission rejection on zero-delta #77375

Merged
merged 2 commits into from
Jun 13, 2019
Merged

Automated cherry pick of #76299: Short-circuit quota admission rejection on zero-delta #77375

merged 2 commits into from
Jun 13, 2019

Conversation

mansi-a
Copy link
Contributor

@mansi-a mansi-a commented May 3, 2019

Cherry pick of #76299 on release-1.13.

#76299: Short-circuit quota admission rejection on zero-delta

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 3, 2019
@k8s-ci-robot
Copy link
Contributor

@mansi-a: All 'parent' PRs of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement.

The following parent PRs have neither the "release-note" nor the "release-note-action-required" labels: #76299.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 3, 2019
@k8s-ci-robot
Copy link
Contributor

@mansi-a: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 3, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @mansi-a. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 3, 2019
@mansi-a
Copy link
Contributor Author

mansi-a commented May 3, 2019 •
edited

/kind bug
/sig api-machinery
/sig release

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/release Categorizes an issue or PR as relevant to SIG Release. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 3, 2019
@k8s-ci-robot
Copy link
Contributor

@mansi-a: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test
/kind bug
/sig api-machinery
/sig release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@imkin
Copy link

imkin commented May 3, 2019

/ok-to-test
/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 3, 2019
@imkin imkin mentioned this pull request May 3, 2019
Closed
@liggitt
Copy link
Member

liggitt commented May 6, 2019

there are compile errors that need fixing in this cherrypick

not a regression in 1.13.
considered a critical fix because objects with finalizers (notably PVCs) cannot be deleted when using global quota.
this was not encountered previously because the configuration is rare.
this PR adds tests that exercise the scenario positively (ensures quota blocks when appropriate) and negatively (ensures quota does not prevent zero-delta updates and deletions).

/priority critical-urgent
/milestone v1.13
/cc @tpepper @aleksandra-malinowska

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label May 6, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone May 6, 2019
@tpepper
Copy link
Member

tpepper commented May 6, 2019

Today's the 1.13.6 cherry pick deadline ahead of Wednesday May 8 release. Please let us know if ya'll are ok with it missing to the next patch release or if we need to watch for it still.

@liggitt
Copy link
Member

liggitt commented May 6, 2019

if this doesn't make it until next patch release, that's ok

@mansi-a mansi-a force-pushed the automated-cherry-pick-of-#76299-upstream-release-1.13 branch from de3952c to c45e37b Compare May 6, 2019 19:38
@mansi-a
Copy link
Contributor Author

mansi-a commented May 6, 2019

/retest

1 similar comment
@mansi-a
Copy link
Contributor Author

mansi-a commented May 6, 2019

/retest

@imkin
Copy link

imkin commented May 7, 2019

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 7, 2019
@tpepper
Copy link
Member

tpepper commented May 30, 2019

@liggitt this still needs lgtm/approve but other wise looks ready...

@liggitt
Copy link
Member

liggitt commented Jun 4, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2019
@derekwaynecarr
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, liggitt, mansi-a

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2019
@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 12, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 12, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit bda90cd into kubernetes:release-1.13 Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@yue9944882 yue9944882 Awaiting requested review from yue9944882

@aleksandra-malinowska aleksandra-malinowska Awaiting requested review from aleksandra-malinowska

@tpepper tpepper Awaiting requested review from tpepper

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mansi-a @k8s-ci-robot @imkin @liggitt @tpepper @derekwaynecarr @fejta-bot