Fix shellcheck failures of cluster/gce/upgrade-aliases.sh #77386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
SataQiu
commented
May 3, 2019
| @@ -26,7 +26,7 @@ if [[ "${KUBERNETES_PROVIDER:-gce}" != "gce" ]]; then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| KUBE_ROOT=$(dirname "${BASH_SOURCE}")/../.. | |||
| KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/../.. | |||
There was a problem hiding this comment.
change reason:
In cluster/gce/upgrade-aliases.sh line 29:
KUBE_ROOT=$(dirname "${BASH_SOURCE}")/../..
^-- SC2128: Expanding an array without an index only gives the first element.
| --project=${PROJECT} --filter='description=k8s-node-route' \ | ||
| local k8s_node_routes_count | ||
| k8s_node_routes_count=$(gcloud compute routes list \ | ||
| --project="${PROJECT}" --filter='description=k8s-node-route' \ |
There was a problem hiding this comment.
change reason:
In cluster/gce/upgrade-aliases.sh line 38:
local k8s_node_routes_count=$(gcloud compute routes list \
^-- SC2155: Declare and assign separately to avoid masking return values.
| --format='value(networkInterfaces[0].subnetwork)') | ||
| if [[ -n ${subnetwork_url} ]]; then | ||
| IP_ALIAS_SUBNETWORK=$(echo ${subnetwork_url##*/}) | ||
| IP_ALIAS_SUBNETWORK=${subnetwork_url##*/} |
There was a problem hiding this comment.
change reason:
In cluster/gce/upgrade-aliases.sh line 57:
IP_ALIAS_SUBNETWORK=$(echo ${subnetwork_url##*/})
^-- SC2116: Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd foo'.
^-- SC2086: Double quote to prevent globbing and word splitting.
| routes+=( "${route}" ) | ||
| done < <(gcloud compute routes list \ | ||
| --project="${PROJECT}" --filter='description=k8s-node-route' \ | ||
| --format='value(name)') |
There was a problem hiding this comment.
change reason:
In ./cluster/gce/upgrade-aliases.sh line 133:
routes=( $(gcloud compute routes list \
^-- SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting).
|
/assign @fejta |
k8s-ci-robot
added
the
lgtm
|
/priority important-longterm |
k8s-ci-robot
added
priority/important-longterm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fejta, SataQiu, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Fix shellcheck failures of cluster/gce/upgrade-aliases.sh
Which issue(s) this PR fixes:
Ref #72956
Special notes for your reviewer:
Does this PR introduce a user-facing change?: