-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subdomain entry to verify dns resolution #77503
Add subdomain entry to verify dns resolution #77503
Conversation
/test pull-kubernetes-e2e-aks-engine-azure-windows |
Hm, I don't think this test is included in the azure-windows job, as it only runs tests tagged with Conformance, NodeConformance, sig-windows, and a few other tags, none of which are included in this test. |
FWIW, the test passes on Windows with these changes: https://paste.ubuntu.com/p/G4V22KYybd/ |
/test pull-kubernetes-e2e-aks-engine-azure-windows |
/assign @johnbelamaric |
@johnbelamaric, This e2e may not run in "pull-kubernetes-e2e-aks-engine-azure-windows" job based on @BCLAU comment #77503 (comment). Could we review and approve this on priority so that #74982 can be closed. |
If this test isn't even running then why is the job failing? I don't really want to merge it with the test failure - why is it failing? Is #77503 (comment) suggesting there is a change that will fix this? |
The job is failing in the cluster setup phase, it's not related to the test. We are looking into it. As mentioned, I've already tested these changes in my cluster and it was fine. Since they use different networking solutions, it's probably a good idea to know if this change also works for @benmoss and @yujuhong . |
This applies to all clusters, not just Windows ones. Why is this Windows specific? |
@benmoss it is not /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnbelamaric, mgdevstack The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history for this PR. Silence the bot with an |
1 similar comment
/retest Review the full test history for this PR. Silence the bot with an |
@mgdevstack: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
When a headless service is created which points to a pod having subdomain specified same as service name, DNS MUST be resolved to it's subdomain DNS entry as well as FQDN. So adding subdomain entry to verify DNS resolution.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
default-subdomain.my-namespace.svc.cluster.local
seems resolvable on Windows.Does this PR introduce a user-facing change?:
/sig testing
/sig windows
/area conformance
cc @BCLAU