Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subdomain entry to verify dns resolution #77503

Merged
merged 1 commit into from
May 14, 2019

Conversation

mgdevstack
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
When a headless service is created which points to a pod having subdomain specified same as service name, DNS MUST be resolved to it's subdomain DNS entry as well as FQDN. So adding subdomain entry to verify DNS resolution.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

None

/sig testing
/sig windows
/area conformance
cc @BCLAU

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/windows Categorizes an issue or PR as relevant to SIG Windows. area/conformance Issues or PRs related to kubernetes conformance tests needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 6, 2019
@k8s-ci-robot k8s-ci-robot requested review from dcbw and freehan May 6, 2019 11:38
@mgdevstack
Copy link
Contributor Author

/test pull-kubernetes-e2e-aks-engine-azure-windows

@claudiubelu
Copy link
Contributor

Hm, I don't think this test is included in the azure-windows job, as it only runs tests tagged with Conformance, NodeConformance, sig-windows, and a few other tags, none of which are included in this test.

@claudiubelu
Copy link
Contributor

FWIW, the test passes on Windows with these changes: https://paste.ubuntu.com/p/G4V22KYybd/

@mgdevstack
Copy link
Contributor Author

Thanks for confirming @BCLAU.
/test pull-kubernetes-e2e-gce
Awaiting for lgtm and approval so that this can be promoted to Conformance in #74982.

@mgdevstack mgdevstack added this to To Triage in conformance-definition May 6, 2019
@mgdevstack mgdevstack moved this from To Triage to In Review in conformance-definition May 6, 2019
@johnbelamaric
Copy link
Member

/test pull-kubernetes-e2e-aks-engine-azure-windows

@timothysc
Copy link
Member

/assign @johnbelamaric

@mgdevstack
Copy link
Contributor Author

@johnbelamaric, This e2e may not run in "pull-kubernetes-e2e-aks-engine-azure-windows" job based on @BCLAU comment #77503 (comment).

Could we review and approve this on priority so that #74982 can be closed.

@johnbelamaric
Copy link
Member

If this test isn't even running then why is the job failing? I don't really want to merge it with the test failure - why is it failing? Is #77503 (comment) suggesting there is a change that will fix this?

@claudiubelu
Copy link
Contributor

If this test isn't even running then why is the job failing? I don't really want to merge it with the test failure - why is it failing? Is #77503 (comment) suggesting there is a change that will fix this?

The job is failing in the cluster setup phase, it's not related to the test. We are looking into it. As mentioned, I've already tested these changes in my cluster and it was fine.

Since they use different networking solutions, it's probably a good idea to know if this change also works for @benmoss and @yujuhong .

@benmoss
Copy link
Member

benmoss commented May 13, 2019

This applies to all clusters, not just Windows ones. Why is this Windows specific?

@johnbelamaric
Copy link
Member

@benmoss it is not

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2019
@johnbelamaric
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, mgdevstack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 14, 2019

@mgdevstack: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-aks-engine-azure-windows 831939b link /test pull-kubernetes-e2e-aks-engine-azure-windows

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 2926505 into kubernetes:master May 14, 2019
conformance-definition automation moved this from In Review to Done May 14, 2019
@mgdevstack mgdevstack deleted the master-subdomain-e2e branch May 14, 2019 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

7 participants