-
Notifications
You must be signed in to change notification settings - Fork 39.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Splits hostname from DNS test #75591
tests: Splits hostname from DNS test #75591
Conversation
At the moment, Windows cannot mount individual files into Containers, which means that the Kubelet-managed hosts file cannot be mounted into the Container, causing the "should provide DNS for pods for Hostname and Subdomain" test to fail. The mentioned test has /etc/hosts file entry checks. This commits separates the DNS check and the /etc/hosts checks into two tests.
d072b17
to
06f1156
Compare
/test pull-kubernetes-e2e-gce-100-performance |
/assign |
When these are promoted to compliance, there will need to be an explanation for the LinuxOnly tag plus a link to the windows KEP section with details. /lgtm |
Is it the checking for the hostname looking at /etc/hosts that is the problem, or the actual functionality does not work on Windows? That is, if it works but the way we checked was wrong, can we fix that with the agnhost image? |
The actual functionality does not work on Windows. Basically, the That is something that will eventually be fixed on Windows once ContainerD support is added, allowing us to be able to do this. When that is done, we will have to switch to the agnhost image. |
Ok, sounds good. /priority important-soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bclau, MrHohn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Subdomain resolution is verified for a headless service based on it's FQDN but not actual subdomain name. On linux platforms, A subdomain If above subdomain resolution is not supported on Windows, does it make sense to add [LinuxOnly] to subdomain e2e with following code addition?
|
The subdomain |
What type of PR is this?
/kind failing-test
/area conformance
/sig testing
/sig windows
What this PR does / why we need it:
At the moment, Windows cannot mount individual files into Containers, which means
that the Kubelet-managed hosts file cannot be mounted into the Container, causing
the
[sig-network] DNS should provide DNS for pods for Hostname and Subdomain
test to fail.
The test mentioned test has
/etc/hosts
file entry checks. This commits separates the DNScheck and the
/etc/hosts
checks into two tests.Which issue(s) this PR fixes:
Related issue: #70189
Related issue: #73425
Special notes for your reviewer:
Does this PR introduce a user-facing change?: