Revert "github.com/beorn7/perks v0.0.0-20180321164747-3a771d992973"

[wojtek-t]

This reverts commit a2ec981.

This is to prove whether this is a commit that cause regression in our tests.
For more context, see #76579

[k8s-ci-robot]

@wojtek-t: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wojtek-t]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[liggitt]

there are two changes this is reverting:

1. a performance improvement that does a pre-allocation of a slice while registering a metric to avoid iterating over a map at runtime.
2. a fix for an off-by-one error when the sample size is very small (hasn't been flushed yet)

I'm skeptical 1 is impacting us, because the extra allocation happens once at register time, and greatly improves speed (with no allocation cost) in the hotpath evaluation at runtime.

If 2 is impacting our metrics, I think that means we were making use of extremely small sample sizes and were gathering bogus data.

That said, the revert is tiny, so we can try it.

/lgtm