Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add webhook converter integration test suite #77756

Merged
merged 1 commit into from
May 22, 2019
Merged

Add webhook converter integration test suite #77756

merged 1 commit into from
May 22, 2019

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented May 10, 2019 •
edited

Adds CRD conversion webhook test coverage for the items listed in the CRD Conversion Webhook Graduation Criteria.

TODO:

--- PASS: TestWebhookConverter (2.91s)
    testserver.go:141: runtime-config=map[api/all:true]
    testserver.go:142: Starting apiextensions-apiserver on port 42677...
    testserver.go:160: Waiting for /healthz to be ok...
    --- PASS: TestWebhookConverter/noop-converter (0.25s)
        --- PASS: TestWebhookConverter/noop-converter/check-0 (0.06s)
            --- PASS: TestWebhookConverter/noop-converter/check-0/v1beta1 (0.02s)
            --- PASS: TestWebhookConverter/noop-converter/check-0/v1beta2 (0.04s)
        --- PASS: TestWebhookConverter/noop-converter/check-1 (0.06s)
            --- PASS: TestWebhookConverter/noop-converter/check-1/v1beta1 (0.04s)
            --- PASS: TestWebhookConverter/noop-converter/check-1/v1beta2 (0.03s)
    --- PASS: TestWebhookConverter/nontrivial-converter (0.25s)
        --- PASS: TestWebhookConverter/nontrivial-converter/check-0 (0.05s)
            helpers.go:42: (*unstructured.Unstructured)(nil)
        --- PASS: TestWebhookConverter/nontrivial-converter/check-1 (0.06s)
            --- PASS: TestWebhookConverter/nontrivial-converter/check-1/v1beta1 (0.00s)
            --- PASS: TestWebhookConverter/nontrivial-converter/check-1/v1beta2 (0.00s)
    --- PASS: TestWebhookConverter/empty-response (0.14s)
        --- PASS: TestWebhookConverter/empty-response/check-0 (0.02s)
            --- PASS: TestWebhookConverter/empty-response/check-0/get (0.00s)
            --- PASS: TestWebhookConverter/empty-response/check-0/list (0.00s)
            --- PASS: TestWebhookConverter/empty-response/check-0/create (0.00s)
            --- PASS: TestWebhookConverter/empty-response/check-0/udpate (0.00s)
            --- PASS: TestWebhookConverter/empty-response/check-0/patch (0.00s)
            --- PASS: TestWebhookConverter/empty-response/check-0/delete (0.00s)
            --- PASS: TestWebhookConverter/empty-response/check-0/deletecollection (0.00s)
            --- PASS: TestWebhookConverter/empty-response/check-0/status-get (0.00s)
            --- PASS: TestWebhookConverter/empty-response/check-0/status-udpate (0.00s)
            --- PASS: TestWebhookConverter/empty-response/check-0/status-patch (0.00s)
            --- PASS: TestWebhookConverter/empty-response/check-0/scale-get (0.00s)
            --- PASS: TestWebhookConverter/empty-response/check-0/scale-udpate (0.00s)
            --- PASS: TestWebhookConverter/empty-response/check-0/scale-patch (0.00s)
    --- PASS: TestWebhookConverter/failure-message (0.15s)
        --- PASS: TestWebhookConverter/failure-message/check-0 (0.03s)
            --- PASS: TestWebhookConverter/failure-message/check-0/get (0.00s)
            --- PASS: TestWebhookConverter/failure-message/check-0/list (0.00s)
            --- PASS: TestWebhookConverter/failure-message/check-0/create (0.00s)
            --- PASS: TestWebhookConverter/failure-message/check-0/udpate (0.00s)
            --- PASS: TestWebhookConverter/failure-message/check-0/patch (0.00s)
            --- PASS: TestWebhookConverter/failure-message/check-0/delete (0.00s)
            --- PASS: TestWebhookConverter/failure-message/check-0/deletecollection (0.00s)
            --- PASS: TestWebhookConverter/failure-message/check-0/status-get (0.00s)
            --- PASS: TestWebhookConverter/failure-message/check-0/status-udpate (0.00s)
            --- PASS: TestWebhookConverter/failure-message/check-0/status-patch (0.00s)
            --- PASS: TestWebhookConverter/failure-message/check-0/scale-get (0.00s)
            --- PASS: TestWebhookConverter/failure-message/check-0/scale-udpate (0.00s)
            --- PASS: TestWebhookConverter/failure-message/check-0/scale-patch (0.00s)
PASS
ok      k8s.io/kubernetes/staging/src/k8s.io/apiextensions-apiserver/test/integration   3.142s

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 10, 2019
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 10, 2019
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/apiserver and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 13, 2019
@jpbetz jpbetz force-pushed the crd-conversion-tests branch 2 times, most recently from 98de342 to f8f4567 Compare May 14, 2019 04:30
@jpbetz jpbetz changed the title [WIP] Add webhook converter integration test suite Add webhook converter integration test suite May 14, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 14, 2019
@jpbetz
Copy link
Contributor Author

jpbetz commented May 14, 2019

@roycaihw @caesarxuchao There are a couple remaining TODOs, but would you be willing to do a 1st pass review of this?

@jpbetz jpbetz mentioned this pull request May 14, 2019
Merged
@jpbetz
Copy link
Contributor Author

jpbetz commented May 14, 2019

cc @sttts @liggitt

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2019
@jpbetz jpbetz force-pushed the crd-conversion-tests branch 3 times, most recently from 8979b5b to 12ca97f Compare May 14, 2019 23:12
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 17, 2019
@sttts sttts added this to the v1.15 milestone May 17, 2019
@sttts sttts added the kind/feature Categorizes issue or PR as related to a new feature. label May 17, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label May 17, 2019
@sttts
Copy link
Contributor

sttts commented May 17, 2019 

staging/src/k8s.io/apiextensions-apiserver/test/integration/convert/webhook.go:83:4: "recieved" is a misspelling of "received"
staging/src/k8s.io/apiextensions-apiserver/test/integration/convert/webhook.go:86:37: "accidently" is a misspelling of "accidentally"

@sttts sttts mentioned this pull request May 17, 2019
Closed
@sttts
Copy link
Contributor

sttts commented May 17, 2019

Sgtm. Just fix the typos and add the bad symbol to the verify script. Then lgtm.

@jpbetz
Copy link
Contributor Author

jpbetz commented May 21, 2019

Sorry for the delay @sttts, I'll get this updated and ready for merge today.

@jpbetz jpbetz force-pushed the crd-conversion-tests branch 3 times, most recently from 5bbce40 to 2f5aaab Compare May 21, 2019 17:58
@jpbetz
Copy link
Contributor Author

jpbetz commented May 21, 2019

Outstanding issues fixed incl the vendor issue reported by pull-kubernetes-dependencies. I'll keep an eye on prow results.

@liggitt
Copy link
Member

liggitt commented May 21, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2019
@jpbetz
Copy link
Contributor Author

jpbetz commented May 21, 2019

Had to re-run update-bazel.sh

@roycaihw
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2019
@jpbetz
Copy link
Contributor Author

jpbetz commented May 21, 2019

/retest

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label May 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit 932d803 into kubernetes:master May 22, 2019
@roycaihw
Copy link
Member

/area custom-resources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts sttts left review comments

@roycaihw roycaihw roycaihw left review comments

@deads2k deads2k Awaiting requested review from deads2k

@yue9944882 yue9944882 Awaiting requested review from yue9944882

Assignees

@sttts sttts

@liggitt liggitt

@roycaihw roycaihw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/custom-resources area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.15
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jpbetz @sttts @liggitt @k8s-ci-robot @roycaihw