Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use declare -g in build #78048

Merged
merged 1 commit into from
May 18, 2019
Merged

Don't use declare -g in build #78048

merged 1 commit into from
May 18, 2019

Conversation

cblecker
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
declare -g isn't bash 3 compatible, and isn't needed either because we aren't using declare inside of a shell function.

Which issue(s) this PR fixes:
Fixes #78047

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 17, 2019
@cblecker cblecker requested a review from adisky May 17, 2019 19:24
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2019
@cblecker cblecker requested a review from BenTheElder May 17, 2019 19:24
@cblecker
Copy link
Member Author

/priority critical-urgent
/sig release

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/release Categorizes an issue or PR as relevant to SIG Release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 17, 2019
@dims
Copy link
Member

dims commented May 17, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tpepper
Copy link
Member

tpepper commented May 17, 2019 •
edited

Works for me, tested on top of release-1.14 branch plus the intermediate changes introduced into master via #77985 and #77910 and #77362. These four commits should be cherry picked to 1.14.

@BenTheElder
Copy link
Member

BenTheElder commented May 17, 2019 •
edited

huhhh:
image

/test pull-kubernetes-kubemark-e2e-gce-big

@yastij
Copy link
Member

yastij commented May 17, 2019 •
edited

/lgtm

do we have (a documented) version we recommend for bash ? latest ?

cc @kubernetes/bash-firefighters

@tpepper
Copy link
Member

tpepper commented May 17, 2019 •
edited

This may not fix things ... @jiatongw notes testing the four cherry picks on 1.14 that make WHAT=cmd/kubectl 'KUBE_BUILD_PLATFORMS=darwin/amd64 windows/amd64' failed:

kubernetes/hack/lib/golang.sh: line 305: KUBE_SERVER_PLATFORMS[@]: unbound variable

More info needed from them...

@jiatongw jiatongw mentioned this pull request May 17, 2019
Closed
@cblecker
Copy link
Member Author

/override pull-kubernetes-kubemark-e2e-gce-big

@k8s-ci-robot
Copy link
Contributor

@cblecker: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • pull-kubernetes-kubemark-e2e-gce-big

Only the following contexts were expected:

  • pull-kubernetes-bazel-build
  • pull-kubernetes-bazel-test
  • pull-kubernetes-cross
  • pull-kubernetes-dependencies
  • pull-kubernetes-e2e-gce
  • pull-kubernetes-e2e-gce-100-performance
  • pull-kubernetes-e2e-gce-device-plugin-gpu
  • pull-kubernetes-integration
  • pull-kubernetes-node-e2e
  • pull-kubernetes-typecheck
  • pull-kubernetes-verify
  • tide

In response to this:

/override pull-kubernetes-kubemark-e2e-gce-big

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cblecker
Copy link
Member Author

/skip pull-kubernetes-kubemark-e2e-gce-big

@cblecker
Copy link
Member Author

/skip

@cblecker
Copy link
Member Author

/test pull-kubernetes-kubemark-e2e-gce-big

@tpepper tpepper mentioned this pull request May 18, 2019
Merged
@k8s-ci-robot k8s-ci-robot merged commit a67f128 into kubernetes:master May 18, 2019
@cblecker cblecker deleted the fix-bash-build branch May 18, 2019 07:25
@cblecker cblecker mentioned this pull request May 19, 2019
Merged
k8s-ci-robot added a commit that referenced this pull request May 19, 2019
@k8s-ci-robot
Merge pull request #78082 from cblecker/automated-cherry-pick-of-#77362-
39fc3c4 
#77910-#77985-#78048-#78059-upstream-release-1.14

Automated cherry pick of #77362: Don't use mapfile as it isn't bash 3 compatible #77910: fix unbound array variable #77985: fix unbound variable release.sh #78048: Don't use declare -g in build #78059: Check KUBE_SERVER_PLATFORMS existence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisky adisky Awaiting requested review from adisky

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

Assignees

@dims dims

@yastij yastij

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MacOS build broken (again) by bash
6 participants
@cblecker @dims @k8s-ci-robot @tpepper @BenTheElder @yastij