Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use declare -g in build #78048

Merged
merged 1 commit into from
May 18, 2019
Merged

Don't use declare -g in build #78048

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions hack/lib/golang.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,10 +163,10 @@ kube::golang::dedup() {
# to readonly.
# The configured vars will only contain platforms allowed by the
# KUBE_SUPPORTED* vars at the top of this file.
declare -a -g KUBE_SERVER_PLATFORMS
declare -a -g KUBE_CLIENT_PLATFORMS
declare -a -g KUBE_NODE_PLATFORMS
declare -a -g KUBE_TEST_PLATFORMS
declare -a KUBE_SERVER_PLATFORMS
declare -a KUBE_CLIENT_PLATFORMS
declare -a KUBE_NODE_PLATFORMS
declare -a KUBE_TEST_PLATFORMS
kube::golang::setup_platforms() {
if [[ -n "${KUBE_BUILD_PLATFORMS:-}" ]]; then
# KUBE_BUILD_PLATFORMS needs to be read into an array before the next
Expand Down Expand Up @@ -219,7 +219,7 @@ kube::golang::setup_platforms() {
KUBE_CLIENT_PLATFORMS=(
darwin/amd64
linux/amd64
)
)
readonly KUBE_CLIENT_PLATFORMS
else
KUBE_TEST_PLATFORMS=(linux/amd64)
Expand Down