Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused events in event.go #78335

Merged
merged 1 commit into from
Jun 16, 2019
Merged

remove unused events in event.go #78335

merged 1 commit into from
Jun 16, 2019

Conversation

mysunshine92
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 25, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @mysunshine92. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 25, 2019
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 25, 2019
mattjmcnaughton
mattjmcnaughton suggested changes May 25, 2019
View reviewed changes
Copy link
Contributor

@mattjmcnaughton mattjmcnaughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

Thanks for this pr!

Could I trouble you to peruse this list and see if there are any other unused events in this pr that we can remove? For example, grepping shows me that HostPortConflict and NodeSelectorMismatching also are unused. (Also, if you don't have time to do this, just lmk and I'm happy to create an additional cleanup PR).

Also, quick gut check... is there ever a situation in which a k8s 1.x cluster could have created an event and a 1.y cluster needs to know how to handle it? So even if the 1.y cluster can't produce the event, we still need to keep it in the code base?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 25, 2019
@mysunshine92
Copy link
Contributor Author

/ok-to-test

Thanks for this pr!

Could I trouble you to peruse this list and see if there are any other unused events in this pr that we can remove? For example, grepping shows me that HostPortConflict and NodeSelectorMismatching also are unused. (Also, if you don't have time to do this, just lmk and I'm happy to create an additional cleanup PR).

Also, quick gut check... is there ever a situation in which a k8s 1.x cluster could have created an event and a 1.y cluster needs to know how to handle it? So even if the 1.y cluster can't produce the event, we still need to keep it in the code base?

thank you for your suggestions. i will open another one PR for clean up work.

@mysunshine92
Copy link
Contributor Author

/assign @tallclair

@mysunshine92
Copy link
Contributor Author

cc @yujuhong
please add an approved label, thanks.

@mysunshine92
Copy link
Contributor Author

cc @cblecker
please add an lgtm and approved label, thanks.

@mysunshine92
Copy link
Contributor Author

cc @derekwaynecarr
please add an lgtm and approved label, thanks.

@cblecker
Copy link
Member

cblecker commented Jun 2, 2019

@mysunshine92 Please note: We are currently in the 1.15 release code freeze and as such this PR will not be able to be merged until that lifts. Thanks for your contribution!

@yujuhong
Copy link
Contributor

yujuhong commented Jun 3, 2019

/lgtm
/approve

As the previous comment said, this won't be merged until the code freeze is lifted. Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mysunshine92, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2019
@mysunshine92
Copy link
Contributor Author

/kind cleanup
/priority backlog

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 16, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 08b4d4b into kubernetes:master Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjmcnaughton mattjmcnaughton mattjmcnaughton requested changes

@resouer resouer Awaiting requested review from resouer

@yifan-gu yifan-gu Awaiting requested review from yifan-gu

Assignees

@yujuhong yujuhong

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mysunshine92 @k8s-ci-robot @cblecker @yujuhong @fejta-bot @mattjmcnaughton @tallclair