Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apiextensions: promote CRD conversion to beta #78426

Merged
merged 5 commits into from May 30, 2019
Merged

apiextensions: promote CRD conversion to beta #78426

merged 5 commits into from May 30, 2019

Conversation

sttts
Copy link
Contributor

@sttts sttts commented May 28, 2019 •
edited

Requires #77743.

CustomResourcesDefinition conversion via webhooks is promoted to beta. It requires that spec.preserveUnknownFields is set to false.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 28, 2019
@sttts sttts changed the title apiextensions: promote CRD conversion to beta WIP: apiextensions: promote CRD conversion to beta May 28, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2019
@sttts sttts added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label May 28, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 28, 2019
@sttts sttts added kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 28, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label May 28, 2019
@sttts sttts added this to the v1.15 milestone May 28, 2019
@sttts sttts added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label May 28, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 28, 2019
@sttts sttts removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 28, 2019
@k8s-ci-robot k8s-ci-robot added area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 28, 2019
@sttts
Copy link
Contributor Author

sttts commented May 28, 2019

/assign @liggitt @jpbetz

@sttts sttts changed the title WIP: apiextensions: promote CRD conversion to beta apiextensions: promote CRD conversion to beta May 28, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2019
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@sttts
Copy link
Contributor Author

sttts commented May 28, 2019

/retest

@jpbetz
Copy link
Contributor

jpbetz commented May 28, 2019 •
edited

Looks correct to me. Do we typically include a test to ensure that the feature is disabled if the gate is turned off for beta features? (not sure one is needed, just curious what our conventions are)

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 29, 2019
@sttts
Copy link
Contributor Author

sttts commented May 29, 2019

/retest

liggitt
liggitt reviewed May 29, 2019
View reviewed changes
staging/src/k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/validation/validation.go Outdated
@@ -343,7 +350,8 @@ func validateCustomResourceConversion(conversion *apiextensions.CustomResourceCo
// ValidateCustomResourceDefinitionSpecUpdate statically validates
func ValidateCustomResourceDefinitionSpecUpdate(spec, oldSpec *apiextensions.CustomResourceDefinitionSpec, established bool, fldPath *field.Path) field.ErrorList {
requireRecognizedVersion := oldSpec.Conversion == nil || hasValidConversionReviewVersionOrEmpty(oldSpec.Conversion.ConversionReviewVersions)
allErrs := validateCustomResourceDefinitionSpec(spec, requireRecognizedVersion, fldPath)

allErrs := validateCustomResourceDefinitionSpec(spec, requireRecognizedVersion, conversionAndPreserveUnknownFields(oldSpec), fldPath)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webhook conversion was previously alpha, I don't think we have to do this check. let's follow-up to remove this and always require preserveUnknownFields:false when using webhook conversion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up #78501

@liggitt
Copy link
Member

liggitt commented May 29, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2019
@liggitt
Copy link
Member

liggitt commented May 29, 2019

needs a rebase

@sttts sttts force-pushed the sttts-crd-conversion-beta branch from f7cb4e6 to dc6d5b9 Compare May 29, 2019 19:30
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2019
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@sttts
Copy link
Contributor Author

sttts commented May 29, 2019

Rebased.

@sttts sttts added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2019
@sttts sttts force-pushed the sttts-crd-conversion-beta branch from dc6d5b9 to c692875 Compare May 29, 2019 19:57
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2019
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@sttts sttts added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2019
@sttts sttts mentioned this pull request May 29, 2019
Merged
@sttts
Copy link
Contributor Author

sttts commented May 30, 2019

/retest

@sttts
Copy link
Contributor Author

sttts commented May 30, 2019

Flake #72493

@k8s-ci-robot k8s-ci-robot merged commit b18846c into kubernetes:master May 30, 2019
@ialidzhikov ialidzhikov mentioned this pull request Jun 22, 2019
Closed
@mengqiy mengqiy mentioned this pull request Aug 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@jpbetz jpbetz

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/custom-resources area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.15
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sttts @fejta-bot @jpbetz @liggitt @k8s-ci-robot