Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #75952: tests: Solve backoff tests flakiness Cherry pick of #75952 on release-1.14. #75952: tests: Solve backoff tests flakiness #78858

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Automated cherry pick of #75952: tests: Solve backoff tests flakiness Cherry pick of #75952 on release-1.14. #75952: tests: Solve backoff tests flakiness #78858

merged 1 commit into from
Sep 13, 2019

Conversation

claudiubelu
Copy link
Contributor

@claudiubelu claudiubelu commented Jun 10, 2019 •
edited

Reason for cherry-picking:

The container status is not constant, and it fluctuates between Running, Terminated, and Waiting, and it is possible for the test to miss any of those transitions, resulting in the test being flaky. This PR eliminates it by treating all the states, rather than just the Terminated state.

Will help improve stability for: https://testgrid.k8s.io/sig-windows#aks-engine-azure-1-14-windows

@claudiubelu
tests: Solve backoff tests flakiness
29f033e 
The container status is not constant, and can change over time in the
following order:

- Running: When kubelet reports the Pod as running. This state is missable if
  the container finishes its command faster than kubelet getting to report this
  state.
- Terminated: After the Container finished its command, it will enter the Terminated
  state, in which will remain for a short period of time, before kubelet will try
  to restart it.
- Waiting: When kubelet has to wait for the backoff period to expire before actually
  restarting the container.

Treating and handling each of these states when calculating the backoff period between
container restarts will make the tests more reliable.
@k8s-ci-robot
Copy link
Contributor

@BCLAU: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 10, 2019
@k8s-ci-robot
Copy link
Contributor

@BCLAU: This PR is not for the master branch but does not have the cherry-pick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.

To approve the cherry-pick, please assign the patch release manager for the release branch by writing /assign @username in a comment when ready.

The list of patch release managers for each release can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 10, 2019
@claudiubelu
Copy link
Contributor Author

/test pull-kubernetes-integration

@claudiubelu
Copy link
Contributor Author

/assign @foxish

@tpepper
Copy link
Member

tpepper commented Jun 20, 2019 •
edited

Is there a reason the cherry pick automation was not used
https://git.k8s.io/community/contributors/devel/sig-release/cherry-picks.md

What is the master branch PR / commit from which this is picked?

/hold

@tpepper
Copy link
Member

tpepper commented Jun 20, 2019

Looks like this is coming from:
#75952
/kind flake
/area conformance
/area test
/sig node
/sig testing
/release-note-none
/priority important-soon

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. area/conformance Issues or PRs related to kubernetes conformance tests sig/node Categorizes an issue or PR as relevant to SIG Node. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 20, 2019
@claudiubelu
Copy link
Contributor Author

Is there a reason the cherry pick automation was not used
https://git.k8s.io/community/contributors/devel/sig-release/cherry-picks.md

What is the master branch PR / commit from which this is picked?

/hold

I followed this guide: https://stupefied-goodall-e282f7.netlify.com/contributors/devel/cherry-picks/

I didn't know of any other guide.

@spiffxp spiffxp added this to To Triage in conformance-definition Jun 20, 2019
@timothysc timothysc removed this from To Triage in conformance-definition Jun 20, 2019
@timothysc timothysc removed the area/conformance Issues or PRs related to kubernetes conformance tests label Jun 20, 2019
@tpepper
Copy link
Member

tpepper commented Aug 6, 2019

@kubernetes/sig-node-pr-reviews looking for lgtm/approve here or close

@tpepper
Copy link
Member

tpepper commented Aug 6, 2019

@kubernetes/sig-testing-pr-reviews also looking for your input

@derekwaynecarr
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2019
@tpepper
Copy link
Member

tpepper commented Sep 13, 2019

/assign @foxish

@foxish
Copy link
Contributor

foxish commented Sep 13, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bclau, derekwaynecarr, foxish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2019
@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 13, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Sep 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3db80af into kubernetes:release-1.14 Sep 13, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enisoc enisoc Awaiting requested review from enisoc

@gmarek gmarek Awaiting requested review from gmarek

Assignees

@foxish foxish

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@claudiubelu @k8s-ci-robot @tpepper @derekwaynecarr @foxish @timothysc