-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.12: Fix incorrect procMount defaulting #78881
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind bug |
/assign @feiskyer @smarterclayton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cherry pick lgtm
/lgtm |
What this PR does / why we need it:
Fixes incorrect forcing of the alpha procMount field to a non-nil value.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):xref #78633
See similar discussion around impact of defaulting fields within pod spec on workload controllers in #69988 and #69445.
Special notes for your reviewer:
This PR allows objects without the alpha field set to remain nil. This prevents unrelated updates to a workload object (like annotating it) from modifying the pod spec portion of the object and forcing a spurious rollout.
I verified this fix prevented spurious rollouts when upgrading from 1.11 to 1.12-with-this-fix with either a
kubectl apply
loop running, or explicit annotation of the workload objects, which would have forced procMount to have been added onrelease-1.12
.Also verified the fix did not cause the reverse problem when upgrading from
release-1.12
to 1.12-with-this-fix followed bykubectl apply
or annotation of the workload objects.Also verified the fix did not prevent legitimate rollouts from occurring (
kubectl apply
of actual changes resulted in a rollout as expected).This also updates the fixtures used in the workload upgrade tests that would have caught this issue.
Similar changes are required in 1.13 and 1.14.
Release note:
/sig apps
/cc @janetkuo @smarterclayton
/priority critical-urgent