Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to go 1.12.6 #78958

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Update to go 1.12.6 #78958

merged 1 commit into from
Jun 20, 2019

Conversation

tao12345666333
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

go1.12.6 (released 2019/06/11) includes fixes to the compiler, the linker,
the go command, and the crypto/x509, net/http, and
os packages. See the Go 1.12.6 milestone on our issue tracker for details.

golang/go@go1.12.5...go1.12.6

update to go 1.12.6

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update to use go 1.12.6

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 13, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @tao12345666333. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 13, 2019
@k8s-ci-robot k8s-ci-robot requested review from fejta and listx June 13, 2019 02:43
@tao12345666333
update to go 1.12.6
37f091e 
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333
Copy link
Member Author

/assign @ixdy @lavalamp PTAL

@k8s-ci-robot
Copy link
Contributor

@tao12345666333: GitHub didn't allow me to assign the following users: PTAL.

Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @ixdy @lavalamp PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@listx
Copy link

listx commented Jun 18, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 18, 2019
@tao12345666333
Copy link
Member Author

tao12345666333 commented Jun 18, 2019 •
edited 

W0618 03:38:20.320] Step 1/16 : FROM k8s.gcr.io/kube-cross:v1.12.6-1
W0618 03:38:20.320] manifest for k8s.gcr.io/kube-cross:v1.12.6-1 not found

we need wait for k8s.gcr.io/kube-cross:v1.12.6-1 image be published.
cc @javier-b-perez

@javier-b-perez
Copy link
Contributor

I'm building now... will post here when the image is ready

@listx
Copy link

listx commented Jun 18, 2019

FYI there is work going on to try to remove Googlers from the critical path (of publishing images for the community) here: https://github.com/kubernetes-sigs/k8s-container-image-promoter. Hopefully it lands for k8s.gcr.io soon.

@javier-b-perez
Copy link
Contributor

/retest
/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2019
@tao12345666333
Copy link
Member Author

/test pull-kubernetes-bazel-test

fejta
fejta reviewed Jun 19, 2019
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit bd35a48 into kubernetes:master Jun 20, 2019
@tao12345666333 tao12345666333 deleted the go-1.12.6 branch June 20, 2019 02:29
@cblecker cblecker mentioned this pull request Aug 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fejta fejta fejta left review comments

@listx listx Awaiting requested review from listx

Assignees

@lavalamp lavalamp

@fejta fejta

@ixdy ixdy

@javier-b-perez javier-b-perez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@tao12345666333 @k8s-ci-robot @listx @javier-b-perez @fejta @lavalamp @ixdy