Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pkg/kubectl/util/rbac to staging #79201

Merged
merged 5 commits into from
Jun 25, 2019
Merged

Move pkg/kubectl/util/rbac to staging #79201

merged 5 commits into from
Jun 25, 2019

Conversation

damemi
Copy link
Contributor

@damemi damemi commented Jun 20, 2019 •
edited

/kind cleanup
/sig cli
/area kubectl

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/cli Categorizes an issue or PR as relevant to SIG CLI. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 20, 2019
@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jun 20, 2019
@damemi
Copy link
Contributor Author

damemi commented Jun 20, 2019

/cc @seans3

@k8s-ci-robot k8s-ci-robot requested a review from seans3 June 20, 2019 12:50
@seans3
Copy link
Contributor

seans3 commented Jun 21, 2019

/cc @monopole

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 21, 2019
@seans3
Copy link
Contributor

seans3 commented Jun 25, 2019

/approve

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 25, 2019
@seans3
Copy link
Contributor

seans3 commented Jun 25, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 25, 2019
@seans3
Copy link
Contributor

seans3 commented Jun 25, 2019

/cc @apelisse
/uncc @monopole
/uncc @derekwaynecarr
/uncc @dchen1107

@k8s-ci-robot k8s-ci-robot requested review from apelisse and removed request for monopole, derekwaynecarr and dchen1107 June 25, 2019 19:30
@seans3
Copy link
Contributor

seans3 commented Jun 25, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2019
soltysh
soltysh approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, seans3, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit 70b1c43 into kubernetes:master Jun 25, 2019
@damemi damemi deleted the kubectl-rbac branch June 25, 2019 22:32
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#79201 from damemi/kubectl-rbac
465b117 
Move pkg/kubectl/util/rbac to staging

Kubernetes-commit: 70b1c43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@seans3 seans3 Awaiting requested review from seans3

@apelisse apelisse Awaiting requested review from apelisse

Assignees

@soltysh soltysh

@seans3 seans3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/kubectl area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@damemi @seans3 @k8s-ci-robot @soltysh