Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pkg/kubectl/util/podutils to staging #79202

Merged
merged 4 commits into from
Jun 24, 2019

Conversation

sallyom
Copy link
Contributor

@sallyom sallyom commented Jun 20, 2019

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/cli Categorizes an issue or PR as relevant to SIG CLI. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 20, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @sallyom. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@damemi
Copy link
Contributor

damemi commented Jun 20, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 20, 2019
@k8s-ci-robot k8s-ci-robot requested review from dims, dshulyak and a team June 20, 2019 03:30
@sallyom sallyom changed the title Mv kubectl util podutils stg Move pkg/kubectl/util/podutils to staging Jun 20, 2019
@sallyom sallyom force-pushed the mv-kubectl-util-podutils-stg branch from 841e387 to c0999f2 Compare June 20, 2019 12:59
@sallyom
Copy link
Contributor Author

sallyom commented Jun 20, 2019

Vendor Verify failed.
If you're seeing this locally, run the below command to fix your directories:
hack/update-vendor.sh

🤷‍♀️ when I run hack/verify-vendor and/or hack/update-vendor I get no diff, locally.
I'm at a loss, help please! : )

@nikhita
Copy link
Member

nikhita commented Jun 20, 2019

Trying update-vendor locally and will update here 👍

@nikhita
Copy link
Member

nikhita commented Jun 20, 2019

@sallyom I get the same diff as that in CI after I rebased on top of master. Your branch doesn't have #78187 right now, and that's one big PR changing lots of dependencies. :)

@sallyom sallyom force-pushed the mv-kubectl-util-podutils-stg branch 2 times, most recently from c485c9b to e4c4d29 Compare June 20, 2019 16:02
@seans3
Copy link
Contributor

seans3 commented Jun 20, 2019

/retest

1 similar comment
@seans3
Copy link
Contributor

seans3 commented Jun 20, 2019

/retest

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Jun 21, 2019
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2019
@soltysh
Copy link
Contributor

soltysh commented Jun 21, 2019

/assign @nikhita
for staging changes approval

@monopole
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: monopole, sallyom, seans3, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2019
@pswica
Copy link
Contributor

pswica commented Jun 21, 2019

/retest

2 similar comments
@pswica
Copy link
Contributor

pswica commented Jun 22, 2019

/retest

@nikhita
Copy link
Member

nikhita commented Jun 22, 2019

/retest

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2019
@seans3
Copy link
Contributor

seans3 commented Jun 22, 2019

/retest

@sallyom sallyom force-pushed the mv-kubectl-util-podutils-stg branch from 815c17e to fbc5c5d Compare June 24, 2019 12:26
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2019
@nikhita
Copy link
Member

nikhita commented Jun 24, 2019

Thanks @sallyom!

/lgtm
/hold cancel
/retest

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 24, 2019
@seans3
Copy link
Contributor

seans3 commented Jun 24, 2019

/uncc dshulyak

@k8s-ci-robot k8s-ci-robot removed the request for review from dshulyak June 24, 2019 18:21
@k8s-ci-robot k8s-ci-robot merged commit 5b23c47 into kubernetes:master Jun 24, 2019
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
…tils-stg

Move pkg/kubectl/util/podutils to staging

Kubernetes-commit: 5b23c47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/kubectl area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants