Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds kubectl logo images #79282

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Adds kubectl logo images #79282

merged 1 commit into from
Jun 25, 2019

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Jun 21, 2019

  • Adds kubectl logo image (in .png format)
  • Adds three different sizes of the image

/kind cleanup
/area kubectl
/sig cli

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 21, 2019
@seans3
Copy link
Contributor Author

seans3 commented Jun 21, 2019

/cc @pwittrock
/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2019
@nikhita
Copy link
Member

nikhita commented Jun 23, 2019

Would be cool to fix the logo in the README as well: https://github.com/kubernetes/kubernetes/tree/master/staging/src/k8s.io/kubectl#kubectl 😍

@seans3
Copy link
Contributor Author

seans3 commented Jun 25, 2019

/cc @Liujingfang1

@Liujingfang1
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2019
@seans3
Copy link
Contributor Author

seans3 commented Jun 25, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit e8738d6 into kubernetes:master Jun 25, 2019
@seans3
Copy link
Contributor Author

seans3 commented Jun 25, 2019

Would be cool to fix the logo in the README as well: https://github.com/kubernetes/kubernetes/tree/master/staging/src/k8s.io/kubectl#kubectl

This PR fixed that issue as well :)

@seans3 seans3 deleted the kubectl-logo branch August 21, 2019 21:53
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#79282 from seans3/kubectl-logo
27b2159 
Adds kubectl logo images

Kubernetes-commit: e8738d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwittrock pwittrock Awaiting requested review from pwittrock

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@shiywang shiywang Awaiting requested review from shiywang

@Liujingfang1 Liujingfang1 Awaiting requested review from Liujingfang1

Assignees

@Liujingfang1 Liujingfang1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@seans3 @k8s-ci-robot @nikhita @Liujingfang1