Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

publishing: fix rules for kubectl #79288

Merged
merged 1 commit into from
Jun 22, 2019
Merged

publishing: fix rules for kubectl #79288

merged 1 commit into from
Jun 22, 2019

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Jun 22, 2019

release-1.15 of kubectl should depend on release-1.15 branch of it's dependencies, not master.

/assign @dims @sttts @soltysh @seans3 @monopole
/priority critical-urgent
/kind bug
/sig cli

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 22, 2019
@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. sig/cli Categorizes an issue or PR as relevant to SIG CLI. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jun 22, 2019
@k8s-ci-robot k8s-ci-robot requested review from dims and sttts June 22, 2019 04:34
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2019
idealhack
idealhack approved these changes Jun 22, 2019
View reviewed changes
Copy link
Member

@idealhack idealhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2019
@nikhita
Copy link
Member Author

nikhita commented Jun 22, 2019

This hasn't published wrong commits yet because there haven't been any new changes in the release-1.15 branch for kubectl, but in case there are, this will publish the wrong go.mod, go.sum and Godeps.json files.

@nikhita nikhita mentioned this pull request Jun 22, 2019
Merged
@seans3
Copy link
Contributor

seans3 commented Jun 22, 2019

/lgtm

@nikhita
Copy link
Member Author

nikhita commented Jun 22, 2019

/test pull-kubernetes-verify

(pod pending timeout)

@k8s-ci-robot k8s-ci-robot merged commit ba85e8a into kubernetes:master Jun 22, 2019
@nikhita nikhita deleted the fix-publishing-rules branch June 22, 2019 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idealhack idealhack idealhack approved these changes

@dims dims Awaiting requested review from dims

@sttts sttts Awaiting requested review from sttts

Assignees

@dims dims

@idealhack idealhack

@soltysh soltysh

@sttts sttts

@monopole monopole

@seans3 seans3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@nikhita @k8s-ci-robot @seans3 @idealhack @dims @soltysh @sttts @monopole