Moving pkg/kubectl/util/storage to staging

[pswica]

• Moves pkg/kubectl/util/storage to staging.
• Publishes this code to the new kubectl repository: https://github.com/kubernetes/kubectl/pkg/util/storage
• Code will be available for re-use after publishing.

/kind cleanup
/sig cli
/area kubectl

NONE

[k8s-ci-robot]

Hi @pswica. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pswica]

/cc @seans3 @soltysh

[seans3]

/ok-to-test

[nikhita]

it looks like client-go is not a dependency yet, can we remove it?

[pswica]

I will fix this too (I was just copying rules from another PR--there are lots for this big move). Thanks again for your review

[pswica]

I re-added this. I think with all of our code moves and re-merging this is now necessary, otherwise tests start failing.

[nikhita]

nit: to be alphabetically consistent, would be better to put api over apimachinery 😛

[pswica]

Great catch! Thanks for reviewing, I will change this.

[nikhita]

Please also add kubectl to https://github.com/kubernetes/kubernetes/blob/master/staging/publishing/import-restrictions.yaml

[pswica]

@nikhita can you help me understand this portion? I'm still new to this codebase and I don't want to update this .yaml in the wrong places.

Please also kubectl to https://github.com/kubernetes/kubernetes/blob/master/staging/publishing/import-restrictions.yaml

[nikhita]

@nikhita can you help me understand this portion? I'm still new to this codebase and I don't want to update this .yaml in the wrong places.

Sure! We want to make sure that certain (staging) packages don't end up importing other staging packges. For example, apimachinery should never depend on another staging repo. These import restrictions are enforced by that yaml file.

For instance, in this:

kubernetes/staging/publishing/import-restrictions.yaml

Lines 33 to 37 in 4e0b764

	- baseImportPath: "./vendor/k8s.io/apimachinery/"
	allowedImports:
	- k8s.io/apimachinery
	- k8s.io/kube-openapi
	- k8s.io/klog

It shows that apimachinery should only depend on kube-openapi and klog (they have the k8s.io imports because they are in the kubernetes GitHub org, but they are not staging repos). If someone adds an import to, say client-go, the tests will fail.

For kubectl, we'll need to add something like https://github.com/kubernetes/kubernetes/pull/79207/files#diff-2c52da2e345c051a2fed16d27e7702a7 to make sure we don't accidentally add any unwanted imports. :)

[pswica]

@nikhita thanks so so much for your thoughtful reviews, I tried to make the suggested changes. You are the best.

[nikhita]

No, no, thank you for making these changes! ❤️

[pswica]

/hold cancel

[seans3]

/priority important-soon

[seans3]

Please remove "staging/publishing/rules.yaml" from this PR. We shouldn't have to change this file anymore. Your changes to this file are only indentation changes, making the indentation inconsistent.

[seans3]

/uncc @dchen1107
/uncc @deads2k

[pswica]

Okay I changed that file. I think that was a remnant of me editing that file before all the merging.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pswica, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/kubectl/OWNERS [soltysh]
• staging/src/k8s.io/kubectl/OWNERS [soltysh]
• vendor/OWNERS [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pswica]

/retest

[seans3]

/lgtm

[seans3]

/retest

[k8s-ci-robot]

@pswica: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-publishing-bot-validate	7b3f8f4e919a0a91ea33d5d33baecfc535e86e13	link	/test pull-publishing-bot-validate

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.