fix test/e2e_node/gubernator.sh shellcheck failures

[BenTheElder]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it: fixes shellcheck failures in test/e2e_node/gubernator.sh

Which issue(s) this PR fixes:

Part of #72956

Special notes for your reviewer: I was hoping nobody used this script still, but it seems the node e2e tests may invoke it :|
Since the fixes are trivial enough, I just went ahead and fixed it. If we can eliminate all failing files we can dramatically speedup and simplify the shellcheck verify script.

Does this PR introduce a user-facing change?:

NONE

/sig node
/priority important-longterm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• hack/OWNERS [BenTheElder]
• test/e2e_node/OWNERS [BenTheElder]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mattjmcnaughton]

/lgtm

Confirming that you ran this script (either locally or via the test suite) and it succeeded?

[mattjmcnaughton]

For my own knowledge - why is -r necessary here?

[BenTheElder]

without -r read will mangle escape sequences. technically it shouldn't matter in this context, but it's a good habit and a correctness fix unless you actually wanted that behavior.

[BenTheElder]

the shellcheck wiki has a good entry on this https://github.com/koalaman/shellcheck/wiki/SC2162

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

[BenTheElder]

Confirming that you ran this script (either locally or via the test suite) and it succeeded?

So actually I did not run it directly as it needs to be part of the suite, I'm not positive that we're still running it but:

• the changes should be safe
• if it does break we'll actually find out where it is being used!

I'm tempted to just delete it as CI shouldn't be using scripts here to craft these uploads, it should be letting Prow do that, but it was quick enough to just fix it.

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

[BenTheElder]

/retest

[mattjmcnaughton]

On Mon, Jun 24, 2019 at 11:48:46AM -0700, Benjamin Elder wrote: > Confirming that you ran this script (either locally or via the test suite) and it succeeded? So actually I did not run it directly as it needs to be part of the suite, I'm not positive that we're still running it but: - the changes should be safe - if it _does_ break we'll actually find out where it is being used! I'm tempted to just delete it as CI shouldn't be using scripts here to craft these uploads, it should be letting Prow do that, but it was quick enough to just fix it. -- You are receiving this because you were assigned. Reply to this email directly or view it on GitHub: #79317 (comment)

Sounds good to me!