-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify elasticsearch script as bash #79407
clarify elasticsearch script as bash #79407
Conversation
/assign @spiffxp |
@@ -1,4 +1,4 @@ | |||
#!/bin/sh | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit history suggests this was set to /bin/sh
in order to "rebase onto alpine", however that's not actually what the image is FROM
today 🤷♂
$ docker run --rm --entrypoint=/bin/sh gcr.io/fluentd-elasticsearch/elasticsearch:v6.7.2 -c 'cat /etc/os-release'
NAME="CentOS Linux"
VERSION="7 (Core)"
ID="centos"
ID_LIKE="rhel fedora"
VERSION_ID="7"
PRETTY_NAME="CentOS Linux 7 (Core)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:centos:centos:7"
HOME_URL="https://www.centos.org/"
BUG_REPORT_URL="https://bugs.centos.org/"
CENTOS_MANTISBT_PROJECT="CentOS-7"
CENTOS_MANTISBT_PROJECT_VERSION="7"
REDHAT_SUPPORT_PRODUCT="centos"
REDHAT_SUPPORT_PRODUCT_VERSION="7"
/remove-sig cluster-lifecycle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/assign @spiffxp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, fejta, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: eliminates shellcheck failure in
cluster/addons/fluentd-elasticsearch/es-image/run.sh
by correcting the shebang to bash.NOTE:
/bin/sh
is bash 4.2. This does not change what shell it actually runs under.$HOSTNAME
is not POSIX, however it is set by bash.Which issue(s) this PR fixes:
part of #72956
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
/kind cleanup
/sig cluster-lifecycle
/priority important-longterm