Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Failing tests] skip test if the server does not serve extensions/v1beta1 since this is deprecated #79778

Merged
merged 1 commit into from
Jul 5, 2019
Merged

[Failing tests] skip test if the server does not serve extensions/v1beta1 since this is deprecated #79778

merged 1 commit into from
Jul 5, 2019

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jul 4, 2019

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
skip deployment should support rollback test if the server does not serve the extensions/v1beta1 api

Which issue(s) this PR fixes:
Fixes #79740

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

/cc @alejandrox1

@cpanato
skip test if the server does not serve extensions/v1beta1 since this …
0fd5632 
…is deprecated

Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@k8s-ci-robot
Copy link
Contributor

@cpanato: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jul 4, 2019
@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 4, 2019
@hoegaarden
Copy link
Contributor

@cpanato

Some questions:

  • Can you point me somewhere to a failing dashboard that shows this issue for 1.15?
  • Why don't we fix in master first and cherry-pick back to older releases (if needed) via the cherry pick process?

@liggitt
Copy link
Member

liggitt commented Jul 4, 2019

The test was already changed in master as part of removing the deprecated API. Picking the entire change back to 1.15 is not appropriate

@liggitt
Copy link
Member

liggitt commented Jul 4, 2019

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2019
@cpanato cpanato mentioned this pull request Jul 4, 2019
Merged
@cpanato
Copy link
Member Author

cpanato commented Jul 5, 2019

@liggitt do we need to add any release notes? the label do-not-merge/release-note-label-needed is in place and also de do-not-merge/cherry-pick-not-approved what is the process for those? thanks!

alejandrox1
alejandrox1 suggested changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

@alejandrox1 alejandrox1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #79747 (review)
We need to evaluate this change against master.
[sig-apps] Deployment deployment should support rollback is passing in 1.15 https://testgrid.k8s.io/sig-release-1.15-blocking#gce-cos-k8sbeta-default

@liggitt
Copy link
Member

liggitt commented Jul 5, 2019

@alejandrox1 this test is failing in the upgrade suite (https://testgrid.k8s.io/sig-release-master-informing#gce-new-master-upgrade-master-parallel) because the release-1.15 tests are being run against a 1.16 API server. This test has already been changed in master. This fix against the release-1.15 branch is required.

@alejandrox1
Copy link
Contributor

Again, thank you @liggitt for the clarification.

/lgtm
/priority critical-urgent
/release-note-none
/cc @kubernetes/patch-release-team

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 5, 2019
@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 5, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jul 5, 2019
@hoegaarden hoegaarden added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 5, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jul 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit e498300 into kubernetes:release-1.15 Jul 5, 2019
@cpanato cpanato deleted the GH-79740 branch July 5, 2019 16:54
@alejandrox1 alejandrox1 mentioned this pull request Jul 8, 2019
Closed
@liggitt liggitt mentioned this pull request Jul 9, 2019
Merged
@alejandrox1 alejandrox1 mentioned this pull request Jul 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrox1 alejandrox1 alejandrox1 requested changes

Assignees

@liggitt liggitt

@alejandrox1 alejandrox1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cpanato @k8s-ci-robot @hoegaarden @liggitt @alejandrox1