Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Failing tests] skip test if the server does not serve extensions/v1beta1 since this is deprecated #79778

Merged
merged 1 commit into from
Jul 5, 2019
Merged

[Failing tests] skip test if the server does not serve extensions/v1beta1 since this is deprecated #79778

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions test/e2e/apps/deployment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import (
"k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/labels"
"k8s.io/apimachinery/pkg/runtime/schema"
"k8s.io/apimachinery/pkg/types"
"k8s.io/apimachinery/pkg/util/intstr"
"k8s.io/apimachinery/pkg/util/wait"
Expand All @@ -53,6 +54,9 @@ const (

var (
nilRs *apps.ReplicaSet

// DeploymentGroupVersionResource identifies a Deployment resource.
DeploymentGroupVersionResource = schema.GroupVersionResource{Group: extensions.GroupName, Version: "v1beta1", Resource: "deployments"}
)

var _ = SIGDescribe("Deployment", func() {
Expand Down Expand Up @@ -509,6 +513,9 @@ func ensureReplicas(rs *apps.ReplicaSet, replicas int32) {
// Then rollback the deployment to revision 10 (doesn't exist in history) should fail.
// Finally, rollback current deployment (revision 4) to revision 4 should be no-op.
func testRollbackDeployment(f *framework.Framework) {
// extensions/v1beta1 is deprecated, only testing if the server serves this api
framework.SkipIfMissingResource(f.DynamicClient, DeploymentGroupVersionResource, f.Namespace.Name)

ns := f.Namespace.Name
c := f.ClientSet
podName := "nginx"
Expand Down