Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to k8s.io/utils/inotify #80092

Closed
3 of 5 tasks
dims opened this issue Jul 12, 2019 · 12 comments · Fixed by #80689 or #81162
Closed
3 of 5 tasks

Switch to k8s.io/utils/inotify #80092

dims opened this issue Jul 12, 2019 · 12 comments · Fixed by #80689 or #81162
Assignees
@Pothulapati @quinton-hoole
Labels
area/code-organization Issues or PRs related to kubernetes code organization kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture.
Projects
code-organization subproject

Comments

@dims
Copy link
Member

dims commented Jul 12, 2019 •
edited

@dims dims added the kind/bug Categorizes issue or PR as related to a bug. label Jul 12, 2019
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jul 12, 2019
@dims
Copy link
Member Author

dims commented Jul 12, 2019

/area code-organization
/sig architecture

cc @Pothulapati @alok87 @rohitsardesai83

@k8s-ci-robot k8s-ci-robot added area/code-organization Issues or PRs related to kubernetes code organization sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 12, 2019
@dims
Copy link
Member Author

dims commented Jul 12, 2019

related to #75526

@dims dims moved this from Backlog to In progress in code-organization subproject Jul 12, 2019
@Pothulapati
Copy link
Contributor

Working on golint issues right now.

@dims
Copy link
Member Author

dims commented Jul 12, 2019 •
edited

/assign @Pothulapati
/assign @rohitsardesai83

@k8s-ci-robot
Copy link
Contributor

@dims: GitHub didn't allow me to assign the following users: rohitsardesai83.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @Pothulapati @rohitsardesai83

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Pothulapati Pothulapati mentioned this issue Jul 12, 2019
Merged
@cpuguy83
Copy link
Contributor

Did you fix the fd leak issues?

@dims
Copy link
Member Author

dims commented Jul 12, 2019

@cpuguy83 this was just migration. please go ahead and file a PR for the fd leak issue specifically

@cpuguy83
Copy link
Contributor

kubernetes/utils#101

@Pothulapati Pothulapati mentioned this issue Jul 18, 2019
Merged
@Pothulapati
Copy link
Contributor

Pothulapati commented Jul 18, 2019 •
edited

  • Fix fd leak
  • Fixing golint issues in k8s.io/utils/inotify
  • Switch cadvisor to use k8s.io/utils/inotify
  • Switch k/k to use k8s.io/utils/inotify

CAdvisor is switched to k8s.io/utils/inotify google/cadvisor#2269

Next, should be switching k/k. :)

@andrewsykim
Copy link
Member

/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jul 25, 2019
@andrewsykim
Copy link
Member

/assign @quinton-hoole

@quinton-hoole quinton-hoole mentioned this issue Jul 26, 2019
Closed
@Pothulapati Pothulapati mentioned this issue Jul 28, 2019
Merged
@dims
Copy link
Member Author

dims commented Jul 29, 2019

@Pothulapati please don't forget to update cadvisor in k/k as well.

@Pothulapati Pothulapati mentioned this issue Aug 8, 2019
Merged
@dims dims moved this from In progress to Completed in code-organization subproject Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pothulapati Pothulapati

@quinton-hoole quinton-hoole

Labels
area/code-organization Issues or PRs related to kubernetes code organization kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture.
Projects
code-organization subproject
Completed
Milestone
No milestone
6 participants
@dims @cpuguy83 @Pothulapati @andrewsykim @k8s-ci-robot @quinton-hoole