Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update guide to make the command works as expected #80424

Merged
merged 1 commit into from Jul 30, 2019
Merged

update guide to make the command works as expected #80424

merged 1 commit into from Jul 30, 2019

Conversation

chendave
Copy link
Member

Signed-off-by: Dave Chen dave.chen@arm.com

What type of PR is this?
/kind documentation

What this PR does / why we need it:
user can run commands successfully by following the guide.
Which issue(s) this PR fixes:
Fixes #80422

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 22, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @chendave. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 22, 2019
@k8s-ci-robot k8s-ci-robot requested review from ixdy and listx July 22, 2019 10:34
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 22, 2019
@ping035627
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 23, 2019
@chendave chendave changed the title doc: update guide to make the command works as expected update guide to make the command works as expected Jul 23, 2019
@chendave
Copy link
Member Author

/assign @mkumatag

@neolit123
Copy link
Member

/cc @BCLAU

@mkumatag
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2019
spiffxp
spiffxp suggested changes Jul 26, 2019
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try cloning with no name, I end up cloning into localhost. I don't think this ever cloned into 8000 since it was added via #19857

spiffxp@spiffxp-macbookpro:agnhost (master %)$ go run agnhost.go fake-gitserver&
[1] 33375
spiffxp@spiffxp-macbookpro:agnhost (master %)$ git clone http://localhost:8000
Cloning into 'localhost'...
warning: You appear to have cloned an empty repository.
spiffxp@spiffxp-macbookpro:agnhost (master %)$ git version
git version 2.18.0

test/images/agnhost/fakegitserver/gitserver.go Outdated Show resolved Hide resolved
test/images/agnhost/README.md Outdated
repo named `8000` on local. You can also use `git clone localhost:8000 my-repo-name` to
rename that repo.
Fakes a git server. When doing `git clone http://localhost:8000`, you will clone an empty git
repo named `8000` on local. You can also use `git clone http://localhost:8000 my-repo-name` to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
repo named `8000` on local. You can also use `git clone http://localhost:8000 my-repo-name` to
repo named `localhost` on local. You can also use `git clone http://localhost:8000 my-repo-name` to

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2019
@chendave
update guide to make the command works as expected
5d268b9 
Signed-off-by: Dave Chen <dave.chen@arm.com>
@spiffxp
Copy link
Member

spiffxp commented Jul 29, 2019

/priority important-longterm
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chendave, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2019
@spiffxp
Copy link
Member

spiffxp commented Jul 30, 2019

/retest

@chendave
Copy link
Member Author

/test pull-kubernetes-dependencies

@chendave
Copy link
Member Author

/test pull-kubernetes-e2e-gce

1 similar comment
@chendave
Copy link
Member Author

/test pull-kubernetes-e2e-gce

@chendave
Copy link
Member Author

/test pull-kubernetes-dependencies

@chendave
Copy link
Member Author

/test pull-kubernetes-kubemark-e2e-gce-big

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit a1a8641 into kubernetes:master Jul 30, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jul 30, 2019
@chendave chendave deleted the doc branch July 13, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@claudiubelu claudiubelu claudiubelu approved these changes

@ixdy ixdy Awaiting requested review from ixdy

@listx listx Awaiting requested review from listx

Assignees

@spiffxp spiffxp

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

doc for "fake-gitserver" need to be updated
8 participants
@chendave @k8s-ci-robot @ping035627 @neolit123 @mkumatag @spiffxp @fejta-bot @claudiubelu