-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update guide to make the command works as expected #80424
Conversation
Hi @chendave. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/assign @mkumatag |
/cc @BCLAU |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I try cloning with no name, I end up cloning into localhost
. I don't think this ever cloned into 8000
since it was added via #19857
spiffxp@spiffxp-macbookpro:agnhost (master %)$ go run agnhost.go fake-gitserver&
[1] 33375
spiffxp@spiffxp-macbookpro:agnhost (master %)$ git clone http://localhost:8000
Cloning into 'localhost'...
warning: You appear to have cloned an empty repository.
spiffxp@spiffxp-macbookpro:agnhost (master %)$ git version
git version 2.18.0
test/images/agnhost/README.md
Outdated
repo named `8000` on local. You can also use `git clone localhost:8000 my-repo-name` to | ||
rename that repo. | ||
Fakes a git server. When doing `git clone http://localhost:8000`, you will clone an empty git | ||
repo named `8000` on local. You can also use `git clone http://localhost:8000 my-repo-name` to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
repo named `8000` on local. You can also use `git clone http://localhost:8000 my-repo-name` to | |
repo named `localhost` on local. You can also use `git clone http://localhost:8000 my-repo-name` to |
Signed-off-by: Dave Chen <dave.chen@arm.com>
/priority important-longterm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chendave, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test pull-kubernetes-dependencies |
/test pull-kubernetes-e2e-gce |
1 similar comment
/test pull-kubernetes-e2e-gce |
/test pull-kubernetes-dependencies |
/test pull-kubernetes-kubemark-e2e-gce-big |
/retest Review the full test history for this PR. Silence the bot with an |
Signed-off-by: Dave Chen dave.chen@arm.com
What type of PR is this?
/kind documentation
What this PR does / why we need it:
user can run commands successfully by following the guide.
Which issue(s) this PR fixes:
Fixes #80422