kubeadm: update the version constants for 1.15 #80834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/cherry-pick-not-approved
k8s-ci-robot
added
size/M
k8s-ci-robot
added
cncf-cla: yes
|
/release-note-none |
k8s-ci-robot
added
release-note-none
- common_test.go: use constants.CurrentKubernetesVersion - diff_test.go: write temporary files instead of using testdata. this allows us to not have to bump kubernetesVersions in the testdata files (now removed) - policy_test.go: apply fixes to tests that were previously passing, but a bump in constants.go breaks them. these tests now work for any version.
neolit123
force-pushed
the
1.15-update-version
branch
from
69bc3cf
to
fc9e04f
Compare
fabriziopandini
approved these changes
Aug 1, 2019
There was a problem hiding this comment.
@neolit123 thanks for this fix!
@ patch team, sorry for the noise. we are changing how to track before release tasks in order to avoid this to happen again
/approve
/lgtm
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rosti
approved these changes
Aug 1, 2019
There was a problem hiding this comment.
Thanks @neolit123 !
Sure, this does more than it's expected, but it's mostly test changes, so I am OK with that.
/lgtm
|
/cc @kubernetes/patch-release-team |
hoegaarden
added
the
cherry-pick-approved
k8s-ci-robot
removed
the
do-not-merge/cherry-pick-not-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is not a cherry pick, but rather we forgot to update some constants in for kubeadm in 1.15.
similar PR for 1.16:
#80833
while this is a cleanup WRT to 1.16, it is a bug in kubeadm 1.15 and can result in problems, if say the user attempt to deploy a version of the cluster that is way too old.
we have plans to automate the update of these constants except there are complications and they are tracked in: kubernetes/kubeadm#1260
sorry for the noise, patch team.
/assign @fabriziopandini @rosti
/cc @yagonobre
/kind bug
/priority critical-urgent