kubeadm: update the version constants for 1.16 #80833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
size/M
k8s-ci-robot
added
cncf-cla: yes
This was referenced Aug 1, 2019
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
- common_test.go: use constants.CurrentKubernetesVersion - diff_test.go: write temporary files instead of using testdata. this allows us to not have to bump kubernetesVersions in the testdata files (now removed) - policy_test.go: apply fixes to tests that were previously passing, but a bump in constants.go breaks them. these tests now work for any version.
neolit123
force-pushed
the
1.16-update-version
branch
from
9c3d80b
to
8aa69ea
Compare
fabriziopandini
approved these changes
Aug 1, 2019
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/retest Review the full test history for this PR. Silence the bot with an |
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
commit description has details.
this is still an issue:
kubernetes/kubeadm#1260
we are defaulting ClusterConfiguration with a version that resolves a label from the internet and this is such a can of worms.
unit tests wrongly end up calling:
https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/util/config/common.go#L91
and if the bumped minimal CP version in constants.go is newer than the latest stable version from the label we use, this can end up in:
in a large number of unit tests...
Which issue(s) this PR fixes:
xref kubernetes/kubeadm#1260
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/assign @fabriziopandini @rosti
/cc @yagonobre
/priority critical-urgent
/kind cleanup