Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit namespace when kubectl get is for the cluster #80873

Merged
merged 1 commit into from Aug 3, 2019
Merged

Omit namespace when kubectl get is for the cluster #80873

merged 1 commit into from Aug 3, 2019

Conversation

tedyu
Copy link
Contributor

@tedyu tedyu commented Aug 1, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
When kubectl get is for the cluster, the output shouldn't mention namespace.

Which issue(s) this PR fixes:
Fixes #80855

Special notes for your reviewer:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 1, 2019
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 1, 2019
@tedyu
Copy link
Contributor Author

tedyu commented Aug 2, 2019

/test pull-kubernetes-typecheck

@tedyu
Copy link
Contributor Author

tedyu commented Aug 2, 2019

@apelisse
Can you take a look ?

@tedyu
Copy link
Contributor Author

tedyu commented Aug 2, 2019

@apelisse
Your comment has been addressed.

@tedyu
Copy link
Contributor Author

tedyu commented Aug 2, 2019

@apelisse
Your comment has been addressed.

apelisse
apelisse reviewed Aug 2, 2019
View reviewed changes
Copy link
Member

@apelisse apelisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, tedyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2019
@tedyu
Copy link
Contributor Author

tedyu commented Aug 2, 2019

/test pull-kubernetes-e2e-gce

@tedyu
Copy link
Contributor Author

tedyu commented Aug 2, 2019

/test pull-kubernetes-bazel-build

@k8s-ci-robot k8s-ci-robot merged commit f19863c into kubernetes:master Aug 3, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 3, 2019
@luksa luksa mentioned this pull request Aug 3, 2019
Closed
@luksa
Copy link
Contributor

luksa commented Aug 3, 2019 •
edited

Note that these changes have not addressed #80855, but have fixed a related problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apelisse apelisse apelisse left review comments

@rootfs rootfs Awaiting requested review from rootfs

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@apelisse apelisse

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

Confusing message in kubectl get when no cluster-scoped resources found
4 participants
@tedyu @k8s-ci-robot @luksa @apelisse