Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: print the stack trace of an error for klog level v>=5 #80937

Merged
merged 1 commit into from
Aug 22, 2019
Merged

kubeadm: print the stack trace of an error for klog level v>=5 #80937

merged 1 commit into from
Aug 22, 2019

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 commented Aug 3, 2019 •
edited

What this PR does / why we need it:

  • replace all stray calls of os.Exit() with util.CheckError() instead
  • CheckError() now checks if the klog verbosity level is >=5
    and shows a stack trace of the error.
  • don't call klog.Fatal in version.go.

Which issue(s) this PR fixes:

Fixes kubernetes/kubeadm#1266

Special notes for your reviewer:
NONE

Does this PR introduce a user-facing change?:

kubeadm: print the stack trace of an error for klog level --v>=5

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/kind feature
/priority backlog
@kubernetes/sig-cluster-lifecycle-pr-reviews

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. priority/backlog Higher priority than priority/awaiting-more-evidence. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2019
@neolit123
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/kubeadm labels Aug 3, 2019
yagonobre
yagonobre reviewed Aug 5, 2019
View reviewed changes
Copy link
Member

@yagonobre yagonobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neolit123
/lgtm

cmd/kubeadm/app/util/error.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2019
@neolit123
Copy link
Member Author

/assign @timothysc @yastij @rosti

@neolit123
kubeadm: print the stack trace of an error for klog level v>=5
2fc1913 
- replace all stray calls of os.Exit() to util.CheckError() instead
- CheckError() now checks if the klog verbosity level is >=5
and shows a stack trace of the error
- don't call klog.Fatal in version.go
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2019
@neolit123
Copy link
Member Author

neolit123 commented Aug 22, 2019 •
edited

as discussed during the office hours, we didn't end in full +1 vote on this, but i'd say the PR seems good.

/hold cancel
@yagonobre @rosti
PTAL for LGTM.

followups can be:

  • don't call os.Exit() / CheckError in random places, but instead only call it before the application exists. propagate cobra errors up the call stack.
  • always show stack trace on pre-release builds.

i can log issues for these with help-wanted.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2019
yastij
yastij reviewed Aug 22, 2019
View reviewed changes
Copy link
Member

@yastij yastij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2019
@yagonobre
Copy link
Member

LGTM, Thanks @neolit123

@neolit123 neolit123 mentioned this pull request Aug 22, 2019
Closed
@k8s-ci-robot k8s-ci-robot merged commit 59f5b3d into kubernetes:master Aug 22, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ereslibre ereslibre ereslibre left review comments

@rosti rosti rosti left review comments

@yastij yastij yastij left review comments

@yagonobre yagonobre yagonobre left review comments

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@kad kad Awaiting requested review from kad

Assignees

@timothysc timothysc

@rosti rosti

@yastij yastij

@yagonobre yagonobre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

Improve error handling
7 participants
@neolit123 @k8s-ci-robot @yagonobre @ereslibre @rosti @yastij @timothysc