Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples for RC with PodTemplate ref #8109

Closed
kazegusuri opened this issue May 12, 2015 · 5 comments
Closed

examples for RC with PodTemplate ref #8109

kazegusuri opened this issue May 12, 2015 · 5 comments
Assignees
@caesarxuchao
Labels
kind/documentation Categorizes issue or PR as related to documentation. kind/support Categorizes issue or PR as a support question. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@kazegusuri
Copy link
Contributor

PodTemplate is now available as a resource type, and it seems to be able to use in RC. But there are no examples, and Template is validated as required field. Still need more work?
@nikhiljindal nikhiljindal added kind/documentation Categorizes issue or PR as related to documentation. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels May 12, 2015
@nikhiljindal
Copy link
Contributor

@smarterclayton @bgrant0607

@bgrant0607
Copy link
Member

Yes, it needs more work. It isn't fully implemented. We either should finish it, or remove the field from the API for now.

@bgrant0607 bgrant0607 mentioned this issue May 12, 2015
Closed
@smarterclayton
Copy link
Contributor

It's not terrible to implement. What's the cutoff date in your mind brian to implement it?

@bgrant0607
Copy link
Member

End of May.

If we missed that, we'd just remove ReplicationControllerSpec.TemplateRef, and add it back later with the full implementation.

@thockin thockin added kind/support Categorizes issue or PR as a support question. and removed kind/support Categorizes issue or PR as a support question. priority/support labels May 19, 2015
@bgrant0607
Copy link
Member

@caesarxuchao Please remove ReplicationControllerSpec.TemplateRef from the v1 API for now.

@caesarxuchao caesarxuchao mentioned this issue May 29, 2015
Merged
@bimtauer bimtauer mentioned this issue Nov 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caesarxuchao caesarxuchao

Labels
kind/documentation Categorizes issue or PR as related to documentation. kind/support Categorizes issue or PR as a support question. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@smarterclayton @kazegusuri @caesarxuchao @thockin @bgrant0607 @goltermann @nikhiljindal