Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add service annotation for specifying load balancer's pip with name. #81213

Merged
merged 2 commits into from Aug 13, 2019
Merged

Add service annotation for specifying load balancer's pip with name. #81213

merged 2 commits into from Aug 13, 2019

Conversation

nilo19
Copy link
Member

@nilo19 nilo19 commented Aug 9, 2019 •
edited by feiskyer

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add service annotation for specifying load balancer's pip with name.

Which issue(s) this PR fixes:

Fixes #73235

Does this PR introduce a user-facing change?:

Add a service annotation `service.beta.kubernetes.io/azure-pip-name` to specify the public IP name for Azure load balancer.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 9, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @nilo19. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 9, 2019
@nilo19
Copy link
Member Author

nilo19 commented Aug 9, 2019

/sig azure

@k8s-ci-robot k8s-ci-robot added area/cloudprovider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 9, 2019
@nilo19
Copy link
Member Author

nilo19 commented Aug 9, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 9, 2019
@feiskyer
Copy link
Member

feiskyer commented Aug 9, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 9, 2019
@nilo19 nilo19 force-pushed the t-qini-add_annotation_to_lookup_pip_through_resource_name branch from 56b6297 to ad5151f Compare August 9, 2019 07:10
@feiskyer
Copy link
Member

feiskyer commented Aug 9, 2019

/test pull-kubernetes-e2e-aks-engine-azure

1 similar comment
@nilo19
Copy link
Member Author

nilo19 commented Aug 9, 2019

/test pull-kubernetes-e2e-aks-engine-azure

@feiskyer
Copy link
Member

feiskyer commented Aug 9, 2019

e2e failed because of quota issues:

Operation results in exceeding quota limits of Core. Maximum allowed: 10, Current in use: 8, Additional requested: 8

cc @ritazh

@feiskyer
Copy link
Member

/test pull-kubernetes-e2e-aks-engine-azure

@feiskyer
Copy link
Member

/area provider/azure

@k8s-ci-robot k8s-ci-robot added the area/provider/azure Issues or PRs related to azure provider label Aug 12, 2019
@feiskyer feiskyer self-assigned this Aug 12, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 12, 2019
@nilo19 nilo19 force-pushed the t-qini-add_annotation_to_lookup_pip_through_resource_name branch from f3af604 to 43207cb Compare August 12, 2019 04:38
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 12, 2019
@nilo19 nilo19 force-pushed the t-qini-add_annotation_to_lookup_pip_through_resource_name branch 2 times, most recently from 461d22f to 5ba8c61 Compare August 12, 2019 05:05
@nilo19 nilo19 force-pushed the t-qini-add_annotation_to_lookup_pip_through_resource_name branch from 5ba8c61 to c056017 Compare August 12, 2019 05:18
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2019
@nilo19 nilo19 force-pushed the t-qini-add_annotation_to_lookup_pip_through_resource_name branch from c056017 to 96fc49b Compare August 12, 2019 07:05
@nilo19 nilo19 force-pushed the t-qini-add_annotation_to_lookup_pip_through_resource_name branch from 96fc49b to 3facb63 Compare August 12, 2019 09:24
@feiskyer
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2019
feiskyer
feiskyer approved these changes Aug 13, 2019
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2019
@feiskyer feiskyer mentioned this pull request Aug 13, 2019
Merged
@k8s-ci-robot k8s-ci-robot merged commit a12b648 into kubernetes:master Aug 13, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 13, 2019
@nilo19 nilo19 mentioned this pull request Aug 19, 2019
Closed
6 tasks
@nilo19 nilo19 deleted the t-qini-add_annotation_to_lookup_pip_through_resource_name branch August 20, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

Azure Load Balancer public IP lookup by name
3 participants
@nilo19 @k8s-ci-robot @feiskyer