Fix conflicted cache when the requests are canceled by other Azure operations #81282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
approved
feiskyer
force-pushed
the
fix-az-cancel
branch
from
e6ac7af
to
f692944
Compare
|
/assign @andyzhangx |
|
/test pull-kubernetes-e2e-aks-engine-azure |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Review the full test history for this PR. Silence the bot with an |
k8s-ci-robot
added a commit
that referenced
this pull request
Aug 14, 2019
…82-upstream-release-1.15 Automated cherry pick of #81282: Fix conflicted cache when the requests are canceled by other Azure requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
When a new requests are sending to an Azure resource, the ongoing requests may be canceled with error:
In such case, the resource has already been changed by other requests. So this PR invalidates the cache and then abort the backoff retry. In next controller loop run, cloud provider would GET a new resource from Azure API, and then try updating again.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: Need cherry pick to v1.15.
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/kind bug
/area provider/azure
/priority critical-urgent
/sig cloud-provider