tests: Fixes DNS tests for Windows #81363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous commit replaced the usage of hostname -i with getent hosts in DNS probe commands (for testing IPv6), which breaks the Windows tests (getent hosts is a Linux-specific command that looks into the /etc/hosts file, which, on Windows, is not managed by Kubelet). This commit addresses this issue by executing getent hosts on IPv6 clusters and hostname -i on IPv4 clusters (Windows does not support IPv6 at this moment).
k8s-ci-robot
added
release-note-none
aojea
reviewed
Aug 13, 2019
claudiubelu
force-pushed
the
tests/fixes-dns-tests-for-windows
branch
from
f125f4d
to
a8c63d1
Compare
|
/release v1.16 |
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bclau, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
/sig testing
/sig windows
/area conformance
What this PR does / why we need it:
A previous commit replaced the usage of
hostname -iwithgetent hostsin DNS probe commands (for testing IPv6), which breaks the Windows tests (getent hostsis a Linux-specific command that looks into the/etc/hostsfile, which, on Windows, is not managed by Kubelet).This commit addresses this issue by executing
getent hostson IPv6 clusters andhostname -ion IPv4 clusters (Windows does not support IPv6 at this moment).Which issue(s) this PR fixes:
Fixes #81080
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: