-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename healthz methodNames to be more consistent w/ present day usages #81376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
Denotes a PR that doesn't merit a release note.
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
needs-sig
Indicates an issue or PR lacks a `sig/foo` label and requires one.
needs-priority
Indicates a PR lacks a `priority/foo` label and requires one.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
area/apiserver
area/test
sig/api-machinery
Categorizes an issue or PR as relevant to SIG API Machinery.
sig/auth
Categorizes an issue or PR as relevant to SIG Auth.
sig/cloud-provider
Categorizes an issue or PR as relevant to SIG Cloud Provider.
sig/scheduling
Categorizes an issue or PR as relevant to SIG Scheduling.
sig/testing
Categorizes an issue or PR as relevant to SIG Testing.
and removed
needs-sig
Indicates an issue or PR lacks a `sig/foo` label and requires one.
labels
Aug 13, 2019
logicalhan
force-pushed
the
health-checks
branch
from
August 13, 2019 19:52
f67dd5c
to
2e23788
Compare
/retest |
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
and removed
needs-priority
Indicates a PR lacks a `priority/foo` label and requires one.
labels
Aug 21, 2019
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Aug 21, 2019
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, logicalhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/apiserver
area/test
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
release-note-none
Denotes a PR that doesn't merit a release note.
sig/api-machinery
Categorizes an issue or PR as relevant to SIG API Machinery.
sig/cloud-provider
Categorizes an issue or PR as relevant to SIG Cloud Provider.
sig/scheduling
Categorizes an issue or PR as relevant to SIG Scheduling.
sig/testing
Categorizes an issue or PR as relevant to SIG Testing.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
After introducing readyz health checks, some of these method names are no longer accurate in describing what they function on and how they function. This brings things a bit more in line with the current state today.
Does this PR introduce a user-facing change?: