Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kubectl polymorphic logs helper for ephemeral containers #82010

Merged
merged 1 commit into from Aug 29, 2019
Merged

Update kubectl polymorphic logs helper for ephemeral containers #82010

merged 1 commit into from Aug 29, 2019

Conversation

verb
Copy link
Contributor

@verb verb commented Aug 27, 2019

This also updates the test to check there were actual actions that weren't expected.

What type of PR is this?
/kind cleanup
/priority important-longterm

What this PR does / why we need it: This allows log fetching across multiple containers to include ephemeral containers.

Which issue(s) this PR fixes:

WIP #27140

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@verb
Update kubectl polymorphic logs helper for ephemeral containers
66d0778 
This also updates the test to check there were actual actions that
weren't expected.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 27, 2019
@verb
Copy link
Contributor Author

verb commented Aug 27, 2019

/assign @seans3

@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 27, 2019
@verb verb mentioned this pull request Aug 27, 2019
Closed
9 tasks
@seans3
Copy link
Contributor

seans3 commented Aug 27, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seans3, verb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2019
@seans3
Copy link
Contributor

seans3 commented Aug 27, 2019 •
edited

More context on ephemeral containers:

https://git.k8s.io/enhancements/keps/sig-node/20190212-ephemeral-containers.md

@seans3
Copy link
Contributor

seans3 commented Aug 28, 2019

/milestone 1.16

@k8s-ci-robot
Copy link
Contributor

@seans3: The provided milestone is not valid for this repository. Milestones in this repository: [next-candidate, v1.13, v1.14, v1.15, v1.16, v1.17, v1.18, v1.19]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@seans3
Copy link
Contributor

seans3 commented Aug 28, 2019

/milestone v1.16

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit bdea3c0 into kubernetes:master Aug 29, 2019
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#82010 from verb/range-kubectl
7a7de59 
Update kubectl polymorphic logs helper for ephemeral containers

Kubernetes-commit: bdea3c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adohe-zz adohe-zz Awaiting requested review from adohe-zz

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@seans3 seans3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@verb @seans3 @k8s-ci-robot