Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error out when Scheduler PreBind plugins return Unschedulable #82187

Merged
merged 1 commit into from
Sep 12, 2019
Merged

Error out when Scheduler PreBind plugins return Unschedulable #82187

merged 1 commit into from
Sep 12, 2019
+20 −79

Conversation

ahg-g
Copy link
Member

@ahg-g ahg-g commented Aug 30, 2019

Scheduler PreBind plugins are currently allowed to return Unschedulable status, which should not according to the KEP and comments.

What type of PR is this?
/kind bug

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 30, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 30, 2019
@wgliang
Copy link
Contributor

wgliang commented Aug 31, 2019

/retest
/lgtm
/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 31, 2019
mrkm4ntr
mrkm4ntr reviewed Sep 1, 2019
View reviewed changes
Copy link
Contributor

@mrkm4ntr mrkm4ntr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check is also not necessary.

kubernetes/pkg/scheduler/scheduler.go

Line 638 in 11678fb

if preBindStatus.IsUnschedulable() {

And same for permit plugins?
https://github.com/kubernetes/kubernetes/pull/80416/files#r312374563

@liggitt
Copy link
Member

liggitt commented Sep 11, 2019

/hold

batches including this PR are flaking badly on scheduler integration tests:

please review closely to ensure this is not introducing a regression

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2019
@liggitt
Copy link
Member

liggitt commented Sep 11, 2019

all scheduler-related PRs in the failing batches: #82187 #82209 #82222

This was referenced Sep 11, 2019
Merged
Merged
@ahg-g
Copy link
Member Author

ahg-g commented Sep 11, 2019

all scheduler-related PRs in the failing batches: #82187 #82209 #82222

We suspect that this one is not relevant, so we will cancel the hold on this one and keep it on the other two to see if the integration test becomes green constantly.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2019
@liggitt
Copy link
Member

liggitt commented Sep 11, 2019 •
edited

thanks for checking, see also investigation in #82209 (comment) which seemed to point to #82222

@ahg-g
Copy link
Member Author

ahg-g commented Sep 11, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2019
@ahg-g
Scheduler PreBind plugins are currently allowed to return Unschedulab…
54ac023 
…le status, which should not according to the KEP and comments.
@ahg-g
Copy link
Member Author

ahg-g commented Sep 11, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2019
@Huang-Wei
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2019
@Huang-Wei
Copy link
Member

/retest

@ahg-g
Copy link
Member Author

ahg-g commented Sep 11, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@ahg-g
Copy link
Member Author

ahg-g commented Sep 11, 2019

/test pull-kubernetes-e2e-gce-100-performance

@ahg-g
Copy link
Member Author

ahg-g commented Sep 11, 2019

/test pull-kubernetes-node-e2e

@liggitt
Copy link
Member

liggitt commented Sep 11, 2019

that test job failure is pervasive - fix in kubernetes/test-infra#14291

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 1e70457 into kubernetes:master Sep 12, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 12, 2019
@ahg-g ahg-g deleted the ahg-prebind branch January 10, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrkm4ntr mrkm4ntr mrkm4ntr left review comments

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

@wgliang wgliang Awaiting requested review from wgliang

Assignees

@Huang-Wei Huang-Wei

@wgliang wgliang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ahg-g @k8s-ci-robot @wgliang @liggitt @Huang-Wei @fejta-bot @mrkm4ntr