Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dns capability to GCE window cluster #82314

Merged
merged 1 commit into from Sep 5, 2019
Merged

Add dns capability to GCE window cluster #82314

merged 1 commit into from Sep 5, 2019

Conversation

lzang
Copy link
Contributor

@lzang lzang commented Sep 4, 2019 •
edited

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add dns capability to GCE/GKE window clusters so that dns suffix search list will be programmed for windows pods.

Which issue(s) this PR fixes:
User cannot do dns lookup without full FQDN, such as service name, from their windows pods.

Does this PR introduce a user-facing change?:
None

Fix the dns suffix search list for GCE window clusters.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 4, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @lzang. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 4, 2019
@lzang
Copy link
Contributor Author

lzang commented Sep 4, 2019 •
edited

/sig windows
/assign @yujuhong @pjh

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 4, 2019
pjh
pjh reviewed Sep 4, 2019
View reviewed changes
Copy link
Contributor

@pjh pjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for making this change!

cluster/gce/util.sh Outdated Show resolved Hide resolved
cluster/gce/windows/k8s-node-setup.psm1 Outdated Show resolved Hide resolved
cluster/gce/windows/k8s-node-setup.psm1 Outdated Show resolved Hide resolved
cluster/gce/windows/k8s-node-setup.psm1 Outdated Show resolved Hide resolved
cluster/gce/windows/k8s-node-setup.psm1 Outdated Show resolved Hide resolved
@pjh
Copy link
Contributor

pjh commented Sep 4, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 4, 2019
@lzang lzang force-pushed the master branch 2 times, most recently from ccf6593 to 3d0acaf Compare September 4, 2019 19:36
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 4, 2019
@lzang lzang force-pushed the master branch 2 times, most recently from a584366 to 894dbe6 Compare September 5, 2019 00:00
@pjh
Copy link
Contributor

pjh commented Sep 5, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2019
@pjh
Copy link
Contributor

pjh commented Sep 5, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2019
@lzang
Copy link
Contributor Author

lzang commented Sep 5, 2019

/retest

1 similar comment
@lzang
Copy link
Contributor Author

lzang commented Sep 5, 2019

/retest

yujuhong
yujuhong reviewed Sep 5, 2019
View reviewed changes
Copy link
Contributor

@yujuhong yujuhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a release note so we can cherry-pick?

cluster/gce/util.sh
@@ -872,7 +872,7 @@ function construct-windows-kubelet-flags {
# double-quotes, because they still break sc.exe after expansion in the
# binPath parameter, and single-quotes get parsed as characters instead of
# string delimiters.
flags+=" --resolv-conf="
flags+=" --resolv-conf=${WINDOWS_CNI_CONFIG_DIR}\hostdns.conf"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder: will need to make the change in GKE separately.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 5, 2019
@yujuhong yujuhong added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 5, 2019
@yujuhong
Copy link
Contributor

yujuhong commented Sep 5, 2019

/approve
Thanks for the fix!

@yujuhong yujuhong added this to the v1.16 milestone Sep 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lzang, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit 397ed0e into kubernetes:master Sep 5, 2019
@lzang lzang mentioned this pull request Sep 10, 2019
Merged
k8s-ci-robot added a commit that referenced this pull request Sep 20, 2019
@k8s-ci-robot
Merge pull request #82542 from lzang/automated-cherry-pick-of-#82314-…
05e9e45 
…upstream-release-1.15

Automated cherry pick of #82314: Add dns capability to GCE window cluster
@PatrickLang PatrickLang added this to Done (v1.16) in SIG-Windows Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjh pjh pjh left review comments

@yujuhong yujuhong yujuhong left review comments

@gmarek gmarek Awaiting requested review from gmarek

Assignees

@pjh pjh

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lzang @k8s-ci-robot @pjh @yujuhong