Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove alpha message #82548

Merged
merged 2 commits into from
Sep 12, 2019
Merged

Remove alpha message #82548

merged 2 commits into from
Sep 12, 2019

Conversation

apelisse
Copy link
Member

Update API documentation to remove alpha message about ManagedFields.

What type of PR is this?
/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 10, 2019
@jennybuckley jennybuckley mentioned this pull request Sep 10, 2019
Closed
@k8s-ci-robot k8s-ci-robot added area/code-generation kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 10, 2019
@liggitt
Copy link
Member

liggitt commented Sep 10, 2019 •
edited

/unassign deads2k davidopp
/assign

API docs change that got missed when switching the gate to beta

/wg apply
/sig api-machinery

/priority critical-urgent
/milestone v1.16

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Sep 10, 2019
@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 10, 2019
@liggitt
Copy link
Member

liggitt commented Sep 10, 2019 •
edited

cc @kubernetes/release-team for visibility

no risk (godoc-only change), and doesn't invalidate rc1 testing/feedback. including in the milestone to ensure 1.16 docs are accurate and avoid user confusion

@liggitt
Copy link
Member

liggitt commented Sep 10, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2019
@apelisse
Copy link
Member Author

/retest

1 similar comment
@apelisse
Copy link
Member Author

/retest

@apelisse apelisse mentioned this pull request Sep 10, 2019
Merged
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@josiahbjorgaard
Copy link
Contributor

Bug Triage team on 1.16 release here. Since we have passed code freeze, PRs intended for 1.16 will need to go through approval to be cherry-picked. The deadline for cherry-picks is tomorrow EOD. Description of the approval process for cherry-picks is available here.

@k8s-ci-robot k8s-ci-robot merged commit 89cb15b into kubernetes:master Sep 12, 2019
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.16, v1.17 Sep 12, 2019
k8s-ci-robot added a commit that referenced this pull request Sep 12, 2019
@k8s-ci-robot
Merge pull request #82555 from apelisse/automated-cherry-pick-of-#825…
6a50f6c 
…48-kubernetes-release-1.16

Automated cherry pick of #82548: Remove alpha status from ManagedFields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidopp davidopp Awaiting requested review from davidopp

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@apelisse @liggitt @k8s-ci-robot @fejta-bot @josiahbjorgaard