Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for terminated reason appropriate for containerD and dockershim #82878

Merged
merged 1 commit into from Nov 14, 2019
Merged

Check for terminated reason appropriate for containerD and dockershim #82878

merged 1 commit into from Nov 14, 2019

Conversation

adelina-t
Copy link
Contributor

@adelina-t adelina-t commented Sep 19, 2019 •
edited

Dockershim and containerD return different reasons for container not
starting. This test should check for both in order to pass on both
runtimes.

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 19, 2019
@adelina-t
Copy link
Contributor Author

/cc @BCLAU
/cc @PatrickLang

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 19, 2019
@claudiubelu
Copy link
Contributor

Can confirm that this happens on Containerd, the container has the TerminatedReason StartError, so this should fix the problem.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2019
@nikhita
Copy link
Member

nikhita commented Sep 24, 2019

/kind bug
/assign @PatrickLang

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 24, 2019
@claudiubelu
Copy link
Contributor

/priority priority/important-soon

fix your commit message, which is probably why this was marked as do-not-merge

@k8s-ci-robot
Copy link
Contributor

@BCLAU: The label(s) priority/priority/important-soon, priority/ cannot be applied. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other

In response to this:

/priority priority/important-soon

fix your commit message, which is probably why this was marked as do-not-merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@claudiubelu
Copy link
Contributor

/priority important-soon

@k8s-ci-robot
Copy link
Contributor

@BCLAU: The label(s) priority/ cannot be applied. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other

In response to this:

/priority important-soon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 29, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Nov 5, 2019
@PatrickLang
Copy link
Contributor

/approve

1 similar comment
@PatrickLang
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adelina-t, PatrickLang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2019
@PatrickLang PatrickLang moved this from In progress (v1.17) to In Review (v1.17) in Windows CRI-ContainerD Bring-up Nov 5, 2019
@PatrickLang
Copy link
Contributor

/remove-label do-not-merge/invalid-commit-message

@k8s-ci-robot
Copy link
Contributor

@PatrickLang: The label(s) /remove-label do-not-merge/invalid-commit-message cannot be applied. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other

In response to this:

/remove-label do-not-merge/invalid-commit-message

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@PatrickLang
Copy link
Contributor

@adelina-t can you amend the commit message and remove Fixes: #82876 ?

@PatrickLang PatrickLang mentioned this pull request Nov 6, 2019
Closed
26 tasks
@adelina-t
Check for terminated reason appropriate for containerD and dockershim
3ba4c68 
Dockershim and containerD return different reasons for container not
starting. This test should check for both in order to pass on both
runtimes.
@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Nov 7, 2019
@PatrickLang
Copy link
Contributor

/lgtm
/retest
/milestone v1.17

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 14, 2019
@k8s-ci-robot k8s-ci-robot merged commit b2a2ade into kubernetes:master Nov 14, 2019
Windows CRI-ContainerD Bring-up automation moved this from In Review (v1.17) to Done (v1.17) Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickLang PatrickLang PatrickLang approved these changes

@claudiubelu claudiubelu Awaiting requested review from claudiubelu

@dineshgovindasamy dineshgovindasamy Awaiting requested review from dineshgovindasamy

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@claudiubelu claudiubelu

@PatrickLang PatrickLang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Windows CRI-ContainerD Bring-up
  
Done
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@adelina-t @claudiubelu @nikhita @k8s-ci-robot @PatrickLang