reuse Equal

[m3ngyang]

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
clean up duplicated codes.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

[k8s-ci-robot]

Hi @m3ngyang. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[m3ngyang]

/assign @deads2k
PTAL~

[RainbowMango]

@yue9944882
Maybe you can help.

[RainbowMango]

Should we eliminate redundant functions here?
func Equals(a corev1.ResourceList, b corev1.ResourceList) bool and func V1Equals(a corev1.ResourceList, b corev1.ResourceList) bool.

Bye the way, should we use reflect.DeepEqual() as the function implementation?

[jpbetz]

Eliminating V1Equals might be a backward incompatible change (controllers can depend on this package, right?). But changing in-tree callers of V1Equals (I believe there is only one) to just call Equals instead might be reasonable.

[m3ngyang]

Besides, the performance of reflect.DeepEqual() is much worse than the current implementation.
/assign @liggitt would you mind having a look.

[liggitt]

go ahead and drop the V1Equals function, and update the single caller to call Equals

I agree we should not switch to using DeepEqual internally

[m3ngyang]

V1Equals has been removed in the latest pull request. @liggitt

[liggitt]

/ok-to-test
/lgtm
/approve
/priority backlog

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, m3ngyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/controller/OWNERS [liggitt]
• pkg/quota/v1/OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.