Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using online file instead to fix NUMA nodes init #83196

Merged
merged 1 commit into from
Sep 28, 2019
Merged

using online file instead to fix NUMA nodes init #83196

merged 1 commit into from
Sep 28, 2019

Conversation

zouyee
Copy link
Member

@zouyee zouyee commented Sep 26, 2019 •
edited

What type of PR is this?
/kind bug
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #83175

Special notes for your reviewer:

using /sys/devices/system/node/online instead of /sys/devices/system/node/possible

Does this PR introduce a user-facing change?:

Use online nodes instead of possible nodes when discovering available NUMA nodes

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

using online instead to fix kubelet service failed with wrong number …
b1f6974 
…of possible NUMA nodes

Signed-off-by: Zou Nengren <zouyee1989@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 26, 2019
@k8s-ci-robot
Copy link
Contributor

@zouyee: GitHub didn't allow me to request PR reviews from the following users: tsrjzq.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @tsrjzq @cblecker

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 26, 2019
@zouyee
Copy link
Member Author

zouyee commented Sep 26, 2019 •
edited

@tsrjzq PTAL

@k8s-ci-robot
Copy link
Contributor

@zouyee: GitHub didn't allow me to request PR reviews from the following users: tsrjzq.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @tsrjzq

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zouyee
Copy link
Member Author

zouyee commented Sep 26, 2019

/assign @balajismaniam

odinuge
odinuge approved these changes Sep 27, 2019
View reviewed changes
Copy link
Member

@odinuge odinuge left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I think the comment should be updated too, to make it clear why we should use online and not possible.

I guess this problem occurs when a machine has more cpu sockets than it has cpus installed (eg. 1 socket with a cpu, and one empty one).

Ref. the TODO: This is a temporary workaround until cadvisor provides this we should probably think about this when implementing the discovery in cadvisor too.

/lgtm
/priority important-soon
/cc klueska ConnorDoyle lmdaly
ref. #49964 https://github.com/kubernetes/community/blob/cd961fad1e9d1c2c2ddf85e36a2f93c202c1da89/contributors/design-proposals/node/topology-manager.md

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 27, 2019
ConnorDoyle
ConnorDoyle approved these changes Sep 28, 2019
View reviewed changes
Copy link
Contributor

@ConnorDoyle ConnorDoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/approve

pkg/kubelet/cm/cpumanager/topology/topology.go
@@ -293,7 +293,7 @@ func GetNUMANodeInfo() (NUMANodeInfo, error) {
// nil NUMANodeInfo, indicating that no NUMA information is available
// on this machine. This should implicitly be interpreted as having a
// single NUMA node with id 0 for all CPUs.
nodelist, err := ioutil.ReadFile("/sys/devices/system/node/possible")
nodelist, err := ioutil.ReadFile("/sys/devices/system/node/online")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorDoyle, zouyee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit be1574b into kubernetes:master Sep 28, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 28, 2019
@odinuge
Copy link
Member

odinuge commented Sep 28, 2019

I think this deserves a backport into the v1.16 release branch. Would you care to make that @zouyee?

@zouyee zouyee mentioned this pull request Sep 29, 2019
Merged
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 30, 2019
k8s-ci-robot added a commit that referenced this pull request Oct 11, 2019
@k8s-ci-robot
Merge pull request #83277 from zouyee/automated-cherry-pick-of-#83196…
ff564e2 
…-upstream-release-1.16

Automated cherry pick of #83196: using online instead to fix kubelet service failed with wrong
@klueska klueska mentioned this pull request Nov 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConnorDoyle ConnorDoyle ConnorDoyle approved these changes

@odinuge odinuge odinuge approved these changes

@cblecker cblecker Awaiting requested review from cblecker

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@vishh vishh Awaiting requested review from vishh

@klueska klueska Awaiting requested review from klueska

@lmdaly lmdaly Awaiting requested review from lmdaly

Assignees

@odinuge odinuge

@balajismaniam balajismaniam

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

kubelet service failed with wrong number of possible NUMA nodes
6 participants
@zouyee @k8s-ci-robot @odinuge @ConnorDoyle @balajismaniam @derekwaynecarr