Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding fakeGetPodsAssignedToNode to node lifecycle controller tests #83248

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Adding fakeGetPodsAssignedToNode to node lifecycle controller tests #83248

merged 1 commit into from
Sep 30, 2019

Conversation

krzysied
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Setup for #81167

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 27, 2019
@krzysied krzysied mentioned this pull request Sep 27, 2019
Merged
@krzysied
Copy link
Contributor Author

/assign @wojtek-t

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 27, 2019
@wojtek-t
Copy link
Member

@krzysied - this doesn't compile

@wojtek-t
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzysied, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit c544082 into kubernetes:master Sep 30, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 30, 2019
@krzysied krzysied deleted the node_controller_test branch September 30, 2019 10:56
This was referenced Mar 9, 2020
Merged
Merged
Closed
k8s-ci-robot added a commit that referenced this pull request Mar 10, 2020
@k8s-ci-robot
Merge pull request #88959 from mborsz/automated-cherry-pick-of-#82489-#…
ef1ba35 
…82884-#83248-#83320-#83780-#84445-#81167-upstream-release-1.16

Automated cherry pick of fix for #77733 (NodeLifecycleController is overloading kube-apiserver) into release-1.16
k8s-ci-robot added a commit that referenced this pull request Mar 11, 2020
@k8s-ci-robot
Merge pull request #88962 from mborsz/automated-cherry-pick-of-#81416-#…
af93bbe 
…81839-#82489-#82884-#83248-#83320-#83780-#84445-#81167-upstream-release-1.15

Automated cherry pick of fix for #77733 (NodeLifecycleController is overloading kube-apiserver) into release-1.15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aveshagarwal aveshagarwal Awaiting requested review from aveshagarwal

@gmarek gmarek Awaiting requested review from gmarek

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@krzysied @wojtek-t @k8s-ci-robot