Remove direct reference to prometheus from kubelet #83279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/kubelet
sig/node
20 tasks
mattjmcnaughton
approved these changes
Sep 29, 2019
There was a problem hiding this comment.
/assign @derekwaynecarr
Confirming this doesn't actually cause any functionality changes? If that's the case, then lgtm.
/lgtm
k8s-ci-robot
added
the
lgtm
|
LGTM |
|
/assign @Random-Liu @yujuhong |
|
/lgtm /cc @dashpole |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango, yujuhong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
RainbowMango
deleted the
pr_remove_direct_reference_to_prometheus_from_kubelet
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Remove direct reference to Prometheus.
To get metrics stability into Beta, we will make it illegal to directly import prometheus methods in Kubernetes components.
Which issue(s) this PR fixes:
Refer kubernetes/enhancements#1238
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/priority important-soon