Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused method reciever for CSITranslator #83626

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Remove unused method reciever for CSITranslator #83626

merged 1 commit into from
Oct 8, 2019

Conversation

davidz627
Copy link
Contributor

/sig storage
/priority backlog
/kind cleanup

/assign @misterikkit

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. priority/backlog Higher priority than priority/awaiting-more-evidence. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 8, 2019
@davidz627 davidz627 mentioned this pull request Oct 8, 2019
Merged
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2019
@davidz627
Copy link
Contributor Author

/assign @msau42

misterikkit
misterikkit approved these changes Oct 8, 2019
View reviewed changes
Copy link

@misterikkit misterikkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2019
@k8s-ci-robot k8s-ci-robot merged commit 5c8d219 into kubernetes:master Oct 8, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 8, 2019
@davidz627 davidz627 deleted the fix/removeUnused branch October 8, 2019 23:35
ohsewon pushed a commit to ohsewon/kubernetes that referenced this pull request Oct 16, 2019
@k8s-ci-robot @ohsewon
Merge pull request kubernetes#83626 from davidz627/fix/removeUnused
db23703 
Remove unused method reciever for CSITranslator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misterikkit misterikkit misterikkit approved these changes

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@misterikkit misterikkit

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@davidz627 @k8s-ci-robot @misterikkit @msau42