Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix string trim func isBackendPoolOnSameLB in azure #83953

Merged
merged 1 commit into from Nov 7, 2019
Merged

fix string trim func isBackendPoolOnSameLB in azure #83953

merged 1 commit into from Nov 7, 2019

Conversation

beautytiger
Copy link

What type of PR is this?
/kind bug

What this PR does / why we need it:
TrimRight should be corrected to TrimSuffix since it's string based trimming.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/cc @liggitt
/assign @liggitt

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 15, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 15, 2019
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 15, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @beautytiger. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/cloudprovider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 15, 2019
@beautytiger
Copy link
Author

/unassign @liggitt
/assign @andyzhangx

@k8s-ci-robot k8s-ci-robot assigned andyzhangx and unassigned liggitt Oct 15, 2019
@liggitt
Copy link
Member

liggitt commented Oct 15, 2019

the fix looks good, a unit test demonstrating the bug would be good as well

fix string trim func isBackendPoolOnSameLB in azure
51db06a 
add a test case to prove this trimming bugfix
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 15, 2019
@beautytiger
Copy link
Author

the fix looks good, a unit test demonstrating the bug would be good as well

Good idea. A test case is added to prove this fix, although the test case is a little unusual in real life.

@andyzhangx
Copy link
Member

/ok-to-test
/test pull-kubernetes-e2e-aks-engine-azure

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 16, 2019
@beautytiger
Copy link
Author

/retest

@beautytiger
Copy link
Author

Shall we go on? @andyzhangx

andyzhangx
andyzhangx approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, beautytiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2019
@andyzhangx
Copy link
Member

@beautytiger thanks for the fix, looks like this is a bug need to cherry-pick, we should never use TrimRight

@andyzhangx
Copy link
Member

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit dc255c6 into kubernetes:master Nov 7, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 7, 2019
@ingvagabund ingvagabund mentioned this pull request Nov 16, 2019
Closed
@beautytiger
Copy link
Author

@beautytiger thanks for the fix, looks like this is a bug need to cherry-pick, we should never use TrimRight

@andyzhangx
Thanks for your reminding. Let me do the cherry-pick work.
And which branch shall I target to?

This was referenced Nov 21, 2019
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Nov 27, 2019
@k8s-ci-robot
Merge pull request #85510 from beautytiger/automated-cherry-pick-of-#…
e79798e 
…83953-upstream-release-1.15

Automated cherry pick of #83953: fix string trim func isBackendPoolOnSameLB in azure
k8s-ci-robot added a commit that referenced this pull request Nov 27, 2019
@k8s-ci-robot
Merge pull request #85509 from beautytiger/automated-cherry-pick-of-#…
ee59384 
…83953-upstream-release-1.16

Automated cherry pick of #83953: fix string trim func isBackendPoolOnSameLB in azure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@beautytiger @k8s-ci-robot @liggitt @andyzhangx