Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new label to indicate what is managing an EndpointSlice #83965

Merged
merged 1 commit into from Nov 12, 2019
Merged

Adding new label to indicate what is managing an EndpointSlice #83965

merged 1 commit into from Nov 12, 2019

Conversation

robscott
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
This adds a new Label to EndpointSlices that will ensure that multiple controllers or entities can manage subsets of EndpointSlices. This label provides a way to indicate the controller or entity responsible for managing an EndpointSlice.

To provide a seamless upgrade from the alpha release of EndpointSlices that did not support this label, a temporary annotation has been added on Services to indicate that this label has been initially set on EndpointSlices. That annotation will be set automatically by the EndpointSlice controller with this commit once appropriate Labels have been added on the corresponding EndpointSlices.

Special notes for your reviewer:
This is dependent on the associate proposal PR getting approved.

Does this PR introduce a user-facing change?:

Adds a new label to indicate what is managing an EndpointSlice.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig network
/priority important-longterm
/cc @freehan

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Oct 15, 2019
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@robscott
Copy link
Member Author

/retest

1 similar comment
@robscott
Copy link
Member Author

/retest

@robscott robscott mentioned this pull request Oct 25, 2019
Merged
8 tasks
@freehan
Copy link
Contributor

freehan commented Nov 7, 2019

Given the recent change in ipFamily, is this still needed?

@freehan freehan self-assigned this Nov 7, 2019
freehan
freehan reviewed Nov 8, 2019
View reviewed changes
Copy link
Contributor

@freehan freehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

pkg/controller/endpointslice/endpointslice_controller.go Outdated Show resolved Hide resolved
freehan
freehan reviewed Nov 8, 2019
View reviewed changes
pkg/controller/endpointslice/endpointslice_controller.go Outdated
if managedBySetup, ok := service.Annotations[managedBySetupAnnotation]; !ok || managedBySetup != managedBySetupCompleteValue {
err = c.setupManagedBy(service)
if err != nil {
c.eventRecorder.Eventf(service, v1.EventTypeWarning, "FailedToLabelEndpointSlices",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FailedToLabelEndpointSlices reason seems to be misleading

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's hard to come up with a good but somewhat concise summary of what this is. I ended up changing this to FailedToSetEndpointSliceManagedByLabel, hopefully that's not too long.

@robscott
Adding new label to indicate what is managing an EndpointSlice
6b8b2ff 
This adds a new Label to EndpointSlices that will ensure that multiple
controllers or entities can manage subsets of EndpointSlices. This
label provides a way to indicate the controller or entity responsible
for managing an EndpointSlice.

To provide a seamless upgrade from the alpha release of EndpointSlices
that did not support this label, a temporary annotation has been added
on Services to indicate that this label has been initially set on
EndpointSlices. That annotation will be set automatically by the
EndpointSlice controller with this commit once appropriate Labels have
been added on the corresponding EndpointSlices.
@robscott
Copy link
Member Author

robscott commented Nov 8, 2019

/assign @thockin

freehan
freehan reviewed Nov 11, 2019
View reviewed changes
Copy link
Contributor

@freehan freehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2019
thockin
thockin reviewed Nov 12, 2019
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freehan, robscott, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit 5dc87d2 into kubernetes:master Nov 12, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 12, 2019
@robscott robscott deleted the endpointslice-managed-by branch March 11, 2021 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freehan freehan freehan left review comments

@thockin thockin thockin left review comments

Assignees

@freehan freehan

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@robscott @fejta-bot @freehan @k8s-ci-robot @thockin