Enhance for loops of ViewHistorys

[whs-dot-hk]

What would you like to be added:

kubernetes/staging/src/k8s.io/kubectl/pkg/polymorphichelpers/history.go

Line 118 in 4568c61

for _, rs := range allRSs {

When revision > 0
we could break out of the for loop
once we got the info

Why is this needed:
Finish faster

/sig cli

[ZP-AlwaysWin]

I don't quite understand what you mean. The reason for the loop is that even if revision > 0, it should need to traverse the history details.

[whs-dot-hk]

Hi, I mean

for all rs
  v is the revision return from deploymentutil.Revision
  // keep the logic
  if revision supplied in argument > 0 and v == revision
    break
  endif
endfor

[zhouya0]

I think it's ok to do break for the loop. Because the the function will return the specfic info when revision >0.

kubernetes/staging/src/k8s.io/kubectl/pkg/polymorphichelpers/history.go

Lines 137 to 145 in 4568c61

	if revision > 0 {
	// Print details of a specific revision
	template, ok := historyInfo[revision]
	if !ok {
	return "", fmt.Errorf("unable to find the specified revision")
	}
	return printTemplate(template)
	}

[ZP-AlwaysWin]

It seems like a good idea. You can try to optimize it.

[whs-dot-hk]

/assign

[whs-dot-hk]

It seems like a good idea. You can try to optimize it.

Thx

[whs-dot-hk]

Hi, done

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.