Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote node lease to GA #84351

Merged
merged 1 commit into from Nov 8, 2019
Merged

Promote node lease to GA #84351

merged 1 commit into from Nov 8, 2019

Conversation

wojtek-t
Copy link
Member

@wojtek-t wojtek-t commented Oct 25, 2019 •
edited

Ref kubernetes/enhancements#589

Promote NodeLease feature to GA.
The feature make Lease object changes an additional healthiness signal from Node. Together with that, we reduce frequency of NodeStatus updates to 5m by default in case of no changes to status itself

@wojtek-t wojtek-t added this to the v1.17 milestone Oct 25, 2019
@wojtek-t wojtek-t self-assigned this Oct 25, 2019
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 25, 2019
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 25, 2019
@wojtek-t wojtek-t force-pushed the promote_node_lease_to_GA branch 3 times, most recently from 7a3d9e6 to b8977dc Compare October 28, 2019 09:46
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 28, 2019
@wojtek-t wojtek-t added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 28, 2019
@wojtek-t wojtek-t added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 28, 2019
@wojtek-t
Copy link
Member Author

/retest

@wojtek-t wojtek-t changed the title [WIP] Promote node lease to GA Promote node lease to GA Nov 5, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2019
@wojtek-t wojtek-t assigned derekwaynecarr and unassigned wojtek-t Nov 5, 2019
@wojtek-t
Copy link
Member Author

wojtek-t commented Nov 5, 2019

@derekwaynecarr - I think this is ready for review

@annajung annajung mentioned this pull request Nov 6, 2019
Closed
6 tasks
derekwaynecarr
derekwaynecarr approved these changes Nov 8, 2019
View reviewed changes
Copy link
Member

@derekwaynecarr derekwaynecarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wojtek-t
Copy link
Member Author

wojtek-t commented Nov 8, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit ae15368 into kubernetes:master Nov 8, 2019
@wojtek-t wojtek-t deleted the promote_node_lease_to_GA branch December 18, 2019 08:27
ekeih pushed a commit to syseleven/linkerd-helm that referenced this pull request Feb 10, 2020
Skip linkerd checks for Kubernetes >=1.17.0
94556aa 
Due to kubernetes/kubernetes#84351 we have to
skip the checks until linkerd/linkerd2#3947 is
released by upstream.
@ekeih ekeih mentioned this pull request Feb 10, 2020
Merged
ekeih pushed a commit to syseleven/linkerd-helm that referenced this pull request Feb 10, 2020
Skip linkerd checks for Kubernetes >=1.17.0
325f913 
Due to kubernetes/kubernetes#84351 we have to
skip the checks until linkerd/linkerd2#3947 is
released by upstream.
@dengyufeng2206 dengyufeng2206 mentioned this pull request Jul 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr derekwaynecarr approved these changes

Assignees

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wojtek-t @k8s-ci-robot @derekwaynecarr