Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moves kubectl get subcommand to staging #84540

Merged
merged 3 commits into from Oct 31, 2019
Merged

Moves kubectl get subcommand to staging #84540

merged 3 commits into from Oct 31, 2019

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Oct 29, 2019

  • Moves kubectl get subcommand to staging
  • Updates BUILD files to accommodate move

/kind cleanup
/sig cli
/area kubectl
/priority important-soon

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/cli Categorizes an issue or PR as relevant to SIG CLI. area/kubectl priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 29, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/dependency Issues or PRs related to dependency changes and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 29, 2019
@seans3
Copy link
Contributor Author

seans3 commented Oct 30, 2019

/assign @liggitt

@seans3
Copy link
Contributor Author

seans3 commented Oct 30, 2019

/cc @soltysh

liggitt
liggitt reviewed Oct 30, 2019
View reviewed changes
staging/src/k8s.io/kubectl/pkg/cmd/get/BUILD
"//test/e2e/testing-manifests:all-srcs",
"//test/fixtures",
],
data = ["//staging/src/k8s.io/kubectl/test/data"],
Copy link
Member

@liggitt liggitt Oct 30, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preexisting, but I'm slightly surprised this wasn't under testdata. Any reason not to rename the folder in a follow-up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I'll change it in the next PR. This was my fault in a previous PR.

@liggitt
Copy link
Member

liggitt commented Oct 30, 2019

/lgtm
/approve

finally! :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit ecec5cb into kubernetes:master Oct 31, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 31, 2019
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#84540 from seans3/kubectl-get-staging
2ba9448 
Moves kubectl get subcommand to staging

Kubernetes-commit: ecec5cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@deads2k deads2k Awaiting requested review from deads2k

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seans3 @liggitt @k8s-ci-robot